gtri / orafile Goto Github PK

From #3:

To create reproduceable testcases we had to sort the nodes (no problem if you stick to List<> when manipulating the datastructure).

Empty parameters should be shown as "" - if you leave them blank, Oracle uses the default value instead.
To create reproduceable testcases we had to sort the nodes (no problem if you stick to List<> when manipulating the datastructure).
See code https://gist.github.com/RLieske/8542554 (I kept the differences small to ease integration).

The parser handles escaped quotes in strings (e.g. (KEY = "val\"ue")), so the renderer should output them that way.

Hi,

you are using System.lineSeparator() in your code which is a Java 7 method. But the maven-compiler-plugin is configured to use 1.6.

Currently we can parse but not format into the .ora file format.

The formatting is actually the easier direction, but I just haven't done it because I have no need for that functionality right now.

The renderer should be configurable among these options:

• Quote everything with double quotes
• Quote everything with single quotes
• Don't quote anything
• Choose whether to quote based on the string content (this should be the default)

See issue #9.

There is a method to add new nodes to the tree. It would be good, to also have the functionality to delete nodes (matching some criteria, like node.getName().equals(criteria)).
The node should be removed from both list and map.

Move this repo to https://github.com/gtri/

I'll also add a config option to OrafileRenderer to set it explicitly, so you can opt out of platform-specific behavior without having to change a system property.

From #3:

Empty parameters should be shown as "" - if you leave them blank, Oracle uses the default value instead.

If you add the following line (note: it should be two backslashes, I just had to enter 4 to make it look like that)
ADR_BASE_LISTENER = "C:\Oracle"
to render-test.ora, the testcase testRender() will fail, because the backslashes are doubled (you get 4 when rendering).

can you extend the visibility of the following constructors & methods:
- OrafileRenderer(boolean sortByKey)
so one can write
return new OrafileRenderer(sortByKey).renderFile(this.tns);
instead of
return new OrafileRenderer().sortByKey(sortByKey).renderFile(this.tns);

- List OrafileRenderer.defs(OrafileDict dict)
just in case some other sort order is requested