Coder Social home page Coder Social logo

Comments (12)

cowboy avatar cowboy commented on August 19, 2024

If people were concerned about outside access, they could just use their OS firewall to block that... but I'm finding the benefit of just being able to connect to a dev server from another machine to be incredibly useful.

from grunt-contrib-connect.

eddiemonge avatar eddiemonge commented on August 19, 2024

Per the docs, if the desire is to allow all ips to work, then it should be changed to hostname: '*' https://github.com/gruntjs/grunt-contrib-connect#hostname

from grunt-contrib-connect.

eddiemonge avatar eddiemonge commented on August 19, 2024

I think it should stay localhost and those that know what they are doing and want to allow others to connect can change their ip to *. Keep the security for the newer people are people who arent aware and let the more advanced people change it.

from grunt-contrib-connect.

cowboy avatar cowboy commented on August 19, 2024

Think about it this way:

Default to localhost, Gruntfile uses defaults

  • Someone who doesn't want or care about outside access doesn't need to do anything.
  • Someone who wants outside access has to modify their Gruntfile to change this option, which is an inconveince and risks accidentally committing this change to the project.

Default to 0.0.0.0, Gruntfile uses defaults

  • Someone who wants outside access doesn't need to do anything.
  • Someone who doesn't want or care about outside access doesn't have to touch the Gruntfile or modify the project in any way, it just works. They can enable their OS firewall if they're concerned, however, which they've probably already done if they're aware of issues like this.

I think it's more helpful to not have to modify project files unnecessarily than to worry about whether the developer in question knows what a firewall is. Besides, how often is outside access a problem? I've never joined a public wifi without first enabling my OS firewall, so I've don't really see this as an issue.

I think the benefits of defaulting to 0.0.0.0 far outweigh the drawbacks.

from grunt-contrib-connect.

cowboy avatar cowboy commented on August 19, 2024

/cc @tkellen @shama @vladikoff @sindresorhus

from grunt-contrib-connect.

tkellen avatar tkellen commented on August 19, 2024

Agreed. Do it!

from grunt-contrib-connect.

cowboy avatar cowboy commented on August 19, 2024

FWIW, when I created this task, I misunderstood how binding to localhost worked. Had I known what I know now, I would have definitely used 0.0.0.0 instead.

from grunt-contrib-connect.

vladikoff avatar vladikoff commented on August 19, 2024

Sure! Bump to 0.7.0

from grunt-contrib-connect.

cowboy avatar cowboy commented on August 19, 2024

I'm going to see if there are any other changes first before releasing a new version.

from grunt-contrib-connect.

rienheuver avatar rienheuver commented on August 19, 2024

On my windows 8.1 machine, this actually breaks something for me. 0.0.0.0:35729 will not access the livereload-server. Somehow 0.0.0.0 doesn't look at my machine at all (0.0.0.0:8000 gives an address invalid too).

from grunt-contrib-connect.

vatsalpande avatar vatsalpande commented on August 19, 2024

I am running windows 8 and if I change it to 0.0.0.0 it starts to look for ip address 0.0.0.0 and hence starts giving error

from grunt-contrib-connect.

piotr-dobrogost avatar piotr-dobrogost commented on August 19, 2024

You can't connect with address 0.0.0.0 on Windows – http://stackoverflow.com/a/28230165/95735 Use localhost or address 127.0.0.1 instead when connecting.

from grunt-contrib-connect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.