Comments (12)
If people were concerned about outside access, they could just use their OS firewall to block that... but I'm finding the benefit of just being able to connect to a dev server from another machine to be incredibly useful.
from grunt-contrib-connect.
Per the docs, if the desire is to allow all ips to work, then it should be changed to hostname: '*'
https://github.com/gruntjs/grunt-contrib-connect#hostname
from grunt-contrib-connect.
I think it should stay localhost and those that know what they are doing and want to allow others to connect can change their ip to *
. Keep the security for the newer people are people who arent aware and let the more advanced people change it.
from grunt-contrib-connect.
Think about it this way:
Default to localhost, Gruntfile uses defaults
- Someone who doesn't want or care about outside access doesn't need to do anything.
- Someone who wants outside access has to modify their Gruntfile to change this option, which is an inconveince and risks accidentally committing this change to the project.
Default to 0.0.0.0, Gruntfile uses defaults
- Someone who wants outside access doesn't need to do anything.
- Someone who doesn't want or care about outside access doesn't have to touch the Gruntfile or modify the project in any way, it just works. They can enable their OS firewall if they're concerned, however, which they've probably already done if they're aware of issues like this.
I think it's more helpful to not have to modify project files unnecessarily than to worry about whether the developer in question knows what a firewall is. Besides, how often is outside access a problem? I've never joined a public wifi without first enabling my OS firewall, so I've don't really see this as an issue.
I think the benefits of defaulting to 0.0.0.0
far outweigh the drawbacks.
from grunt-contrib-connect.
/cc @tkellen @shama @vladikoff @sindresorhus
from grunt-contrib-connect.
Agreed. Do it!
from grunt-contrib-connect.
FWIW, when I created this task, I misunderstood how binding to localhost
worked. Had I known what I know now, I would have definitely used 0.0.0.0
instead.
from grunt-contrib-connect.
Sure! Bump to 0.7.0
from grunt-contrib-connect.
I'm going to see if there are any other changes first before releasing a new version.
from grunt-contrib-connect.
On my windows 8.1 machine, this actually breaks something for me. 0.0.0.0:35729 will not access the livereload-server. Somehow 0.0.0.0 doesn't look at my machine at all (0.0.0.0:8000 gives an address invalid too).
from grunt-contrib-connect.
I am running windows 8 and if I change it to 0.0.0.0 it starts to look for ip address 0.0.0.0 and hence starts giving error
from grunt-contrib-connect.
You can't connect with address 0.0.0.0 on Windows – http://stackoverflow.com/a/28230165/95735 Use localhost or address 127.0.0.1 instead when connecting.
from grunt-contrib-connect.
Related Issues (20)
- Can this connect from a remote server to either the web or to my local machine?
- ExperimentalWarning: The http2 module is an experimental API. HOT 6
- forwarding grunt connect to different url HOT 2
- DES3 is a weak cipher
- warning corifeus-builder-angular > grunt-contrib-connect > [email protected]: Use the built-in module in node 9.0.0 or newer, instead HOT 10
- Can I force TLS 1.2? HOT 2
- Can we use this with helmet? HOT 1
- Changing content type of files HOT 2
- Is it possible to configure the mime type returned by grunt-contrib-connect? HOT 1
- Options are just being ignored HOT 1
- This project's build is currently broken. HOT 1
- How to preview a Markdown file?
- Port parameter passed in as string leads to misleading error HOT 1
- Upgrade morgan package, CVE-2019-5413
- Cannot access Angular App hosted on CentOS 7 VM in Windows 10
- Security vulnerability GHSA-6fc8-4gx4-v693 affecting "ws" package (nested dependency) HOT 2
- opn dependency was renamed to `open` HOT 1
- `node-http2` is deprecated. Use node's built in `http2` HOT 6
- Fix vulnerability from websocket dependency: Denial of Service HOT 2
- IPv4 loopback overridden
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grunt-contrib-connect.