Comments (2)
Upon closer inspection, I've noticed that Node.js http2
module only became stable from v10.10.0
onwards.
And since grunt-contrib-connect supports Node.js versions 10 or greater ("engines": { "node": ">=10" }
) it supports all versions of 10.x
release, including earlier ones where the http2 module was still experimental API.
So, from my POV, unless the supported node versions were updated (and thus triggering a major version bump on grunt-contrib-connect to 4.0.0
) we should not move/upgrade to Node.js http2
module.
Which is kinda unfortunate because:
node-http2
repository (which was itself a fork of https://github.com/molnarg/node-http2 /http2
npm package, which since went seemingly unpublished too) was deleted/is nowhere to be found (see here: https://www.npmjs.com/package/node-http2) so one can't submit Issues or PRs to fix the security vulnerability that the latestnode-http2
release/version (4.0.1
) has.node-http2 4.0.1
depends on"websocket-stream": "^5.0.1"
which depends (even on latest version/release5.4.0
) on"ws": "^3.2.0"
, which has a security vulnerability: GHSA-6fc8-4gx4-v693 (I've created the max-mapper/websocket-stream#162 issue to track this).- Lastly, I already had the update to
http2
module ready to go at https://github.com/pedrosanta/grunt-contrib-connect/tree/http2-update.
But again, from my POV:
- Either the Node.js supported versions are updated (new major version), or
- The next best chance to fix the vulnerability is to have
websocket-stream
upgrade theirws
dependency.
PS: Meanwhile I'll update this issue to reference/track the security vulnerability in the first place, moreso than moving to http2
module, etc.
from grunt-contrib-connect.
Closing in favor of #270.
from grunt-contrib-connect.
Related Issues (20)
- Can this connect from a remote server to either the web or to my local machine?
- ExperimentalWarning: The http2 module is an experimental API. HOT 6
- forwarding grunt connect to different url HOT 2
- DES3 is a weak cipher
- warning corifeus-builder-angular > grunt-contrib-connect > [email protected]: Use the built-in module in node 9.0.0 or newer, instead HOT 10
- Can I force TLS 1.2? HOT 2
- Can we use this with helmet? HOT 1
- Changing content type of files HOT 2
- Is it possible to configure the mime type returned by grunt-contrib-connect? HOT 1
- Options are just being ignored HOT 1
- This project's build is currently broken. HOT 1
- How to preview a Markdown file?
- Port parameter passed in as string leads to misleading error HOT 1
- Upgrade morgan package, CVE-2019-5413
- Cannot access Angular App hosted on CentOS 7 VM in Windows 10
- opn dependency was renamed to `open` HOT 1
- `node-http2` is deprecated. Use node's built in `http2` HOT 6
- Fix vulnerability from websocket dependency: Denial of Service HOT 2
- IPv4 loopback overridden
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grunt-contrib-connect.