Coder Social home page Coder Social logo

Comments (21)

daspecster avatar daspecster commented on August 19, 2024

Can anyone verify that this is an issue? Confirm/Deny?

from grunt-contrib-connect.

sindresorhus avatar sindresorhus commented on August 19, 2024

Confirmed. Looks like it was a bug in the connect version we were using. Upgraded connect and seemed to work fine.

Try out 0.2.0 ;)

from grunt-contrib-connect.

daspecster avatar daspecster commented on August 19, 2024

Still seems to be broken :( We have a video coming soon to demonstrate...when vimeo gets doen processing it'll be here... https://vimeo.com/61268804

Video curtesy of @stephenplusplus

from grunt-contrib-connect.

sindresorhus avatar sindresorhus commented on August 19, 2024

Sorry, forgot to npm publish :/

It's up now.

from grunt-contrib-connect.

stephenplusplus avatar stephenplusplus commented on August 19, 2024

Hey @sindresorhus, I actually tested with 0.2.0 by manually cloning it into daspecsters-example-project/node_modules. npm installed, which got [email protected], and then grunt server'd the project. Still clipped the .html at 40k.

Same result by updating the project's /package.json with 0.2.0 for grunt-contrib-connect.

from grunt-contrib-connect.

sindresorhus avatar sindresorhus commented on August 19, 2024

Alright, so I've narrowed it down to the livereloadSnippet, no idea why it worked for me though, might be some unclosed connection or something. Anyway, seems like the html is cut of because the content-length is never set to more than 40kb (that being the max buffer size).

https://github.com/gruntjs/grunt-contrib-livereload/blob/master/lib/utils.js

Can you open an issue on grunt-contrib-livereload?

from grunt-contrib-connect.

daspecster avatar daspecster commented on August 19, 2024

Brilliant! I will do that right now!

https://github.com/gruntjs/grunt-contrib-livereload/issues/25

Thanks for all your help too btw!

from grunt-contrib-connect.

jgallen23 avatar jgallen23 commented on August 19, 2024

I'm still having this issue with the latest grunt-contrib-connect and using livereload: true. Anybody else?

from grunt-contrib-connect.

tschlich avatar tschlich commented on August 19, 2024

same problem here... does not work with grunt-contrib-connect 0.2.0 and 0.5.0

from grunt-contrib-connect.

shama avatar shama commented on August 19, 2024

Would you guys mind opening the issue on https://github.com/intesso/connect-livereload? That is the underlying library that handles this part of the task now. Thanks!

from grunt-contrib-connect.

jgallen23 avatar jgallen23 commented on August 19, 2024

one thing I just noticed is that when I npm install grunt-contrib-connect, I get connect-livereload 0.2.0, but in the git repo, I see connect-livereload: 0.3.0.

from grunt-contrib-connect.

jgallen23 avatar jgallen23 commented on August 19, 2024

confirmed that when connect-livereload 0.3.0 is used the issue goes away. So I think the fix is to publish a new version of grunt-contrib-connect to npm with connect-livereload ~0.3.0 as a dependency.

Just an FYI, if you run npm info grunt-contrib-connect it shows:

dependencies:
   { connect: '~2.7.11',
     'connect-livereload': '~0.2.0',
     open: '0.0.4' },

from grunt-contrib-connect.

andineck avatar andineck commented on August 19, 2024

if you push a new version, please use the latest one of connect-livereload: 0.3.1

from grunt-contrib-connect.

shama avatar shama commented on August 19, 2024

Ah strange. Ok reopening to remind me to do this. Thanks!

from grunt-contrib-connect.

shama avatar shama commented on August 19, 2024

Fixed on 0.6.0.

from grunt-contrib-connect.

razvan-flavius-panda avatar razvan-flavius-panda commented on August 19, 2024

Still getting this bug on the latest grunt-contrib-connect @0.7.1 (it depends on 'connect-livereload': '~0.3.0')

The use case is a html view file being served by AngularJS using XHR. The file served is around 100 KBytes and gets truncated at the end.

from grunt-contrib-connect.

kevin-smets avatar kevin-smets commented on August 19, 2024

This is still an issue for us, has this been looked into further?

from grunt-contrib-connect.

haxaco avatar haxaco commented on August 19, 2024

Same here, our pages are being cut and we're working with grunt contrib watch (0.6.1) and connect (0.9.0). Should we roll back to 0.6.0?

from grunt-contrib-connect.

andineck avatar andineck commented on August 19, 2024

It once was an issue with connect-livereload, but it should have been fixed... I quickly checked the versions: grunt-contrib-connect 0.9.0 uses connect-livereload 0.5.0 (the latest one would be 0.5.0), but this bug was supposed to be fixed in 0.5.0 already.
intesso/connect-livereload@v0.5.0...v0.5.2

there is a test with large files (~2.9MB):
https://github.com/intesso/connect-livereload/blob/master/test/app.render.large-file.js

anyway, can you send me a test file or add a test case to connect-livereload?

from grunt-contrib-connect.

andineck avatar andineck commented on August 19, 2024

I just updated connect-livereload's test dependencies and added another test case with connect and large files. v0.5.3.

The tests run with:
"connect": "^3.3.4",
"express": "~4.11.2",

from grunt-contrib-connect.

andineck avatar andineck commented on August 19, 2024

do you use some other middleware with size limits? e.g.:
https://github.com/expressjs/body-parser#limit

from grunt-contrib-connect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.