assumes host:port style addresses, cannot easily use custom transports, e.g. unix domain sockets about grpc-go

[tv42]

Sorry, I submitted the form too early. Still diagnosing, this might be user error. Will report back soon.

[iamqizhao]

No, it is called in https://github.com/grpc/grpc-go/blob/master/transport/http2_client.go#L113 when some TransportAuthenticator is set in authOpts.

[iamqizhao]

Close now. Please reopen if you still think there is a problem here. Thanks.

[tv42]

Okay here's the better diagnosis: the client lib assumes addresses always have a port. It calls net.SplitHostPort and fails unless the address was host:port style. There's several calls, removing the error path from this makes the greeter example work over unix domain sockets, with a custom Dial:
https://github.com/grpc/grpc-go/blob/master/call.go#L118

[tv42]

Oh, and I can't re-open this issue.

[iamqizhao]

On Thu, Feb 26, 2015 at 2:22 PM, Tv [email protected] wrote:

Okay here's the better diagnosis: the client lib assumes addresses always
have a port. It calls net.SplitHostPort and fails unless the address was

Right now the client lib does not assume addresses always have a port. It
REQUIRES!

host:port style. There's several calls, removing the error path from this
makes the greeter example work over unix domain sockets, with a custom Dial:
https://github.com/grpc/grpc-go/blob/master/call.go#L118

Unix domain socket is not supported now. And I plan to add it in the next a
couple of weeks.

—
Reply to this email directly or view it on GitHub
#72 (comment).

[iamqizhao]

make #73 to track UDS separately.