Comments (2)
I don't know if erroring has been considered and rejected, or if we just didn't think about it (the PR introducing NewClient
has no mention of this option). I could see the argument for accepting those options to make it easier to switch to NewClient
. I am not sure this was the best option: if users do rely on WithBlock
, and since NewClient
is a new function, I suppose that in most cases it's easy enough for users to get rid of those ineffective and deprecated options when they migrate to the new interface. And it makes it even more explicit that the blocking behaviour doesn't apply anymore.
Introducing this error as a breaking change might be OK. @arvindbr8 mentioned that issuing logs might be a reasonable trade-off. We'll wait for @dfawley to decide if we want to do something about it though, to see if those options were considered.
from grpc-go.
Since Dial
calls NewClient
, we'd need to filter these options out there before calling NewClient
. I think the current behavior is fine (even if it's not optimal), and changing it now will be hard, since it would be a breaking behavior change. I'd be inclined to leave things as-is, personally.
from grpc-go.
Related Issues (20)
- Github Action: Codecov action is broken and is failing silently HOT 1
- Upgrade to using math/rand/v2 to get perf enhancements HOT 2
- xds: tests shouldn't rely on the presence of an entry in the `authorities` field of the bootstrap configuration with an empty key
- Experimental API related to metadata HOT 4
- Linter rule for using context.Background() without a timeout in tests HOT 4
- gRPC is incompatible with tls.Listener HOT 2
- Closing connection takes up to 15 minutes. HOT 5
- Feature Request: expose handleRawConn or add ServeConn HOT 21
- Flaky test: TimerAndWatchStateOnErrorCallback HOT 1
- xds: bootstrap config is not emitted to logs in a human readable way
- Strongly-type request inside a Stream Server Interceptor HOT 2
- Proxy connection buffer necessary?
- Make transport.SetConnection public? HOT 4
- what's the default max data size
- If a priority contains multiple localities with pick_first, load is reported incorrectly HOT 4
- NewClient doesn't work with WithContextDialer HOT 2
- xds: make the bootstrap configuration a singleton
- protoc gen adds comment, does not follow godoc. HOT 3
- Flaky test: Test/AggregateCluster_BadDNS_GoodEDS
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from grpc-go.