greyfenrir / cargo Goto Github PK

Hello! Thanks for your time and efforts. You can find some comments about the homework below.

BE

1. No migrations in the repo.
2. CORS_ORIGIN_WHITELIST = ["http://localhost:8080"] -- in my case I had to modify it because 8080 was already occupied.
3. It would be nice to see a bit more complex db schema
4. back.api.test.test_api.APITest.test_get_user_list:29 -- It appears unclear to me. The obtained username is compared to the admin or user. But 'owner' key is used for self.fail statement. I would just omit that 'else' block as it is redundant. If a test fails, let it fail and then investigate the issue.
5. back.api.test.test_api.APITest.test_get_user_details:39 -- it might happen that id would become different
6. back.api.test.test_api.APITest.test_get_shipment_list -- again, if a test fails, let it fail, I don't see a need to use self.fail statement. Just compare the actual response with expected.
7. back.api.test.test_api.APITest.test_add_shipment -- It might be best to divide this test into two parts: creation and permissions. Additionaly, usually you want to make sure that response code is what was expected and then verify that content is in db.
8. len(Shipment.objects.all()) -- Shipment.objects.count()
9. self.assertGreaterEqual(response.status_code, 400) -- why not just self.assertEqual?
10. back.api.test.test_api.APITest.test_delete_shipment -- why 300 code for delete? I think the default is 204

FE

1. What's the reason of using jquery's ajax?
2. No error handling. A user should be notified if something is wrong.

Summary:
I appreciate how the code is organized and not overly confusing, especially the FE section. However, I would expect slightly more advanced methods for testing and model structure.

Please feel free to tackle the issues listed above If you are willing to so. However, I don't want to raise false expectations, so just be aware that our partners are looking for middle+ level.

Do not hesitate to request clarifications on my comments.