grepwood / grepline Goto Github PK

Warnings and errors everywhere. Nothing makes sense.

Occurs only on Windows.

GNU getline returns -1 in such instance.
I don't think grepline should be an indicator for EOF as there is a function designed to do that.

GNU getline cannot read lines ended with only CR, it will read until a LF is encountered.
getline actually stops when CR is detected and makes a distinction: if the next character is LF, this is a Windows line and after buffering, 1 additional byte will need to be skipped.

In any case, lines buffered into memory end with LF so that puts and printf can work with them without bumping into crazy characters like CR.

grepline as of now handles CRLF of Windows and LF of Linux.
It's not prepared to deal with just CR of OSX.
A solution to this would be to check if fgetc'd value after a CR is a LF. If not, fseek(fp,-1,SEEK_CUR), do not increment size, do not add the new char to the end of the string and break the loop.