grepsedawk / celebrity-picture-rater Goto Github PK

View Code? Open in Web Editor NEW

3.0 3.0 2.0 1.28 MB

Celebrity picture rater is a project designed to rate/rank pictures of various celebs.

Home Page: https://celebrity-picture-rater.herokuapp.com/celebrities

License: MIT License

Ruby 81.42% Elm 5.79% JavaScript 2.05% HTML 9.02% CSS 0.29% Shell 1.43%

celebrities ranking rating ruby ruby-on-rails

celebrity-picture-rater's People

Contributors

Stargazers

Watchers

Forkers

waffle-iron bettinson

celebrity-picture-rater's Issues

Add picture minimum for voting

Just simply don't show voting and say something like "please add more pictures for a more fair voting experience... blah blah" (quote from @d4rkd0s)

Remove Fake Picture

De-duplication with dupe-magick

Dupe-magick states, "If you need to look for duplicates which can't otherwise be found via md5 checksums e.g. images of different formats or slightly lossy, then this gem can compare or find duplicates based on euclidian distances between points in an 8x8x8 RGB vector cube."

https://rubygems.org/gems/dupe-magick

I think this would be a great feature to have since there isn't a directory of images users can view so duplicates are starting to become an issue.

Add photo removal method

Or set up dependent: :destroy properly

Prevent "bad" votes by adding a wait timer

For now, this can be implemented in elm directly, I'm thinking somewhere within https://github.com/Mingosio/celebrity-picture-rater/blob/master/app/javascript/Voting.elm#L67-L68, basically the equal to a setTimeout to disable the newest loaded vote, then re-enable the actions after a few seconds.
Also with this piece, it probably makes sense to add some visual cue like a green border flash or equal to depict the chosen image.

Disallow votes cast after vote creation

After vote creation, disallow vote cast after it's been around for 15 minutes. If a vote tries to be cast, simply move forward and say the vote was stale or whatnot. This allows us to "lock" old votes as well as mark some old votes stale that have no chosen picture for later deletion from a scheduled job.

Grid images

@d4rkd0s said he used

.timg {
    height: 150px;
    width: auto;
    margin: 12px;
    transition-duration: 120ms;
    user-select: none;
    border-radius: 8px;
    border: 1px solid transparent;
}

previously

Create a first pass front end styling

According to my users, the user interface sucks. Here's an issue for them to post on.

Since this is to hone in more of my skills, elm + no CSS framework is a must.

Cleanup README.md

The README seems to be some basic Ruby README.md

This issue can be put off until the app is in a more running condition. Whenever you feel fit/best @pachonk slap some kinda basic README for the project together. Tyty 🙏

Intermittent failing spec: Celeb names too exact

Celebrity spec is looking for too exact of a match:

https://circleci.com/gh/Mingosio/celebrity-picture-rater/197

  1) Visitor visits root route displays all celebrities
     Failure/Error: expect(page.body).to include(*celeb_names)
       expected "<!DOCTYPE html>\n<html>\n  <head>\n    <title>CelebrityPictureRater</title>\n    \n\n    <link rel=\...a href=\"/celebrities/4\">Fletcher D&#39;Amore Jr.</a></li></ul>\n    </main>\n  </body>\n</html>\n" to include "Fletcher D'Amore Jr."

Add description to repo

Add a simple description to the top of the repo next to the URL.

As for the URL I added this: https://celebrity-picture-rater.herokuapp.com/celebrities I hope thats okay/valid for now.

Create authentication (mingos.io oauth maybe?)

Auth based off of mingos.io

Community Enhancements

Add Contributing Guide
Add Code of Conduct
Add Issue Template
Add Pull Request Template

Some Pictures are Duplicated

Merging pictures currently doesn't exist and is very tedious to do by hand.
Maybe I can make a little merge function that merges 2 pictures together.
I'm thinking as a developer, I'd like the interface to be:

picture1.merge(picture: picture2)

I'm not sure about the keyword arg.

Feature Suggestion: Show picture percentage and vote count after vote cast

After a vote has been cast, show them what picture they voted for and what picture other people voted for and the percent/count of each.
This is also where I can acknowledge their choice

Suggested Implementation

In Elm, I have FinishVote which can receive the percents and vote stats for that matchup
I also have to stop further votes from being cast during this time

It says that there is no celebrity ID for the foreign key of the vote, I assume this is from the overwritten https://github.com/Mingosio/celebrity-picture-rater/blob/master/spec/support/override_capybara_reset_sessions_for_js_screenshots.rb capybara module method and we reset the session too late after the DB has reset, but before JS can load a vote.