graph-quilt / graph-quilt-gateway Goto Github PK

Describe the bug
Seems like the logback locations provided does not work for everyone.
Probably need to make them generic or use the location of the project directory.

Have you tried starting it up recently?
Not meant to call out, but seeing an issue with RuntimeGraphBuilder build method line 59.
local registry setup does not work, what if I don't have a AWS account? May be provide alternatives.
Probably add documentation on why AWS account if required. What does it do when it runs setup.sh and start.sh in local registry. I think any kind of more documentation can help.

To Reproduce

Startup the application without aws configure.

Expected behavior

Gateway boots up properly.

Additional context
Compilation issues with just mvn clean build

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project graphql-gateway-java: Compilation failure
[ERROR] ...../graph-quilt-gateway/src/main/java/com/intuit/graphql/gateway/graphql/RuntimeGraphBuilder.java:[59,48] incompatible types: invalid method reference
[ERROR] incompatible types: java.lang.Object cannot be converted to com.intuit.graphql.orchestrator.ServiceProvider
[ERROR]

logback xml locations

It will fail to create these folders since not everyone would have root access, so probably change to PROJECT_DIR