Coder Social home page Coder Social logo

comment's Introduction

@GrantBirki

Hello! My name is Grant and I am a Senior Security Engineer at @GitHub.
Previously, I was a security engineer working on CDNs and deployment pipelines for @Nordstrom.

๐Ÿ”ญ I'm currently working on: Automation, security, devops, several open source projects, public Actions workflows, and all things chatops
๐ŸŒฑ I'm currently learning: Rust, JS, and custom GitHub Actions
๐Ÿ’Ž I love Ruby and even maintain a few open source libraries (Gems)
๐Ÿง‘โ€๐Ÿ”ฌ A core contributor for the-hideout and github/branch-deploy

I love to build, learn, support the open source community, and have fun along the way. โค๏ธ:octocat:

Open source projects โญ

๐Ÿ›  Projects โญ Stars
branch-deploy Stars
combine-prs Stars
tarkov-api Stars
tarkov-dev Stars
stash Stars
ghtrending Stars
auditor-action Stars
git-diff-action Stars
json-yaml-validate Stars
issue-template-parser Stars
comment Stars
Fastly Tempo Stars
errbot Stars
upgraded-waffle Stars
cah-generator Stars

Where to find me ๐Ÿ“

Github LinkedIn Medium Website

Stats ๐Ÿ“Š


comment's People

Contributors

dependabot[bot] avatar grantbirki avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar

comment's Issues

feature request: support addint reactions to PR reviews / PR review comments

Currently, there are various ways to leave comment-like messages on GitHub PRs:

For our particular use-case, we'd like to be able to add reactions to all 3 of these types, but it seems that this action doesn't currently support PR reviews / PR review comments.

The following minimized workflow attempts to add a reaction to a PR review comment:

on:
  pull_request_review_comment:
    types: [created, edited]

jobs:
  add_reaction:
    runs-on: ubuntu-latest
    steps:
      - name: Add reaction
        uses: GrantBirki/[email protected]
        with:
          comment-id: ${{ github.event.comment.id }}
          reactions: rocket

However, it fails with:

Adding reaction 'rocket' to comment id 'XXXX' failed with HttpError: Not Found.

Add example for passing a list

Hi ๐Ÿ‘‹

I found out today how to pass a list of arguments via the variables. I struggled a bit and this solution could be beneficial for others, in case you want to add it to the readme/docs.

Here's the setup:

jobs:
  example:
    runs-on: ubuntu-latest
    steps:
      - id: run
        run:  echo "files=a,b,c" >> "$GITHUB_OUTPUT"

      - uses: GrantBirki/comment
        with:
          # other config
          vars: |
            files: ${{ steps.run.outputs.files }}
          body: |
            # Files
            {% for file in files.split(",") %}
            - `{{ file }}`
            {% else %}
            - No file
            {% endfor %}

What's important here is to serialize the files list when passing between steps. Passing a multiline-string breaks the vars value.

Thanks โœจ

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.