grant / dotf Goto Github PK

Thanks to the most recent PR, we have .d.ts files.

We need to publish dotf.

CC @PopGoesTheWza (please create a GitHub issue for every task)

npm test is failed.

npm test

> [email protected] test /Users/prprhyt/gitdir/dotf
> ava


  2 passed
  2 failed

  read

  Rejected promise returned by test. Reason:

  Error {
    code: 'EACCES',
    errno: -13,
    path: '/Users/prprhyt/.myrc3',
    syscall: 'open',
    message: 'EACCES: permission denied, open \'/Users/prprhyt/.myrc3\'',
  }



  write
  /Users/prprhyt/gitdir/dotf/test.js:19

   18:       parseInt(777, 8)).toString(8)) {
   19:     t.fail();                         
   20:   }                                   

  Test failed via `t.fail()`
npm ERR! Test failed.  See above for more details.

It looks like to set wrong permission in 87d53f7#diff-168726dbe96b3ce427e7fedce31bb0bcR36.

fs.chmodSync(fullpath, 600);

It seems to be incorrect.
I think 0600 is correct.
fs.chmodSync's 2nd args is derived from C lang chmod function in sys/stat.h.

int chmod(const char *pathname, mode_t mode);

See:

• http://man7.org/linux/man-pages/man2/chmod.2.html
• https://nodejs.org/api/fs.html#fs_fs_chmodsync_path_mode

I expect to limit dot file permissions to only the owner after this file was created.
See google/clasp#387 .

Expected Behavior

$ ls -g .clasprc.json 
-rw-------  1 staff  583 11 11 23:30 .clasprc.json

Actual Behavior

$ ls -g .clasprc.json 
-rw-r--r--  1 staff  583 11 11 23:30 .clasprc.json

In order to ease contribution and releases of this component

Test suite is slow due to too many os/node version combinations.

Make this faster by reducing number of versions:

The npm does not contain neither the lib/index.js nor the lib/index.d.ts

$ git clone https://github.com/grant/dotf.git
$ cd dotf
$ npm test

> [email protected] test /Users/prprhyt/gitdir/dotf
> ava


  3 passed
  1 failed

  read

  Rejected promise returned by test. Reason:

  Error {
    code: 'ENOENT',
    errno: -2,
    path: '/Users/prprhyt/.myrc',
    syscall: 'open',
    message: 'ENOENT: no such file or directory, open \'/Users/prprhyt/.myrc\'',
  }
npm ERR! Test failed.  See above for more details.

Ava test code run in parallel and test cases access same file(.myrc, myignore).
I think that this is the cause of that error.

I think to solve this problem by changing filename each test or using test.serial.

Specifications

• Node version (node -v): v10.8.0
• OS (Mac/Linux/Windows): macOS High Sierra 10.13.6

Which lock file is valid?