Comments (4)
In addition, I think we should formalize the MetricData format.
in particular:
- what's the purpose of Name?
- what's the purpose of "Metric" ?
- is Name basically Metric, but with tags added into the string? (not really, see monitor_id tag that is not represented into the Name)
- since
Id()
already compiles all tags into the metric ID, why does it still use Name, that seems redundant. it could use the Metric which doesn't have tag info in it? - why does Id need the tags anyway, since the relevant tags are already included in Name, seems like we can just as well use OrgId + Name and don't bother including the tags?
from metrictank.
since we want to adopt metrics2.0, we could also just move org-id, unit and target_type into the tags array. i know we want to implement some sort of validation to make sure those values are actually correctly specified, but we can do that on ingest. or actually, since unit and target_type are mandatory, they could stay, but we could move org-id into the tags. I would like to make all tools in this repo general purpose, not tied to litmus. and i don't think not much needs to happen for that (but making org-id optional would be one thing)
from metrictank.
- what's the purpose of Name?
Graphite format
- what's the purpose of "Metric" ?
Kairosdb metric format
- is Name basically Metric, but with tags added into the string? (not really, see monitor_id tag that is not represented into the Name)
see 1 and 2 above. It is entirely up to the user sending the metric. metric doesnt need to be a subset of name.
- since Id() already compiles all tags into the metric ID, why does it still use Name, that seems redundant. it could use the Metric which doesn't have tag info in it?
Agreed, we should change this.
- why does Id need the tags anyway, since the relevant tags are already included in Name, seems like we can just as well use OrgId + Name and don't bother including the tags?
The entire purpose of the Id is to future proof the schema and allow us to transition away from graphite style naming towards more modern metric+tag naming.
(but making org-id optional would be one thing)
OrgId is mandatory. Everything we build needs to be multi Tenant capable. It is trivial to use a multi-tenant product in a single tenant environment, but you cant do the reverse.
from metrictank.
from metrictank.
Related Issues (20)
- High priority / backlog on metric flush HOT 5
- MT-Whisper-Importer-Writer can get stuck on invalid requests HOT 1
- request: tag-native divide and asPercent functions HOT 9
- Panic and crash in chunk cache
- Graphite API responds with 413 when response is too large not request HOT 5
- Add more logging with traceID HOT 2
- Ability to "revive" archived series HOT 15
- Support "archive" in tags/delByQuery HOT 2
- Stored 'lastupdate' being approximate can cause inconsistent missing data HOT 6
- deletes don't affect stale metrics. They may resurface if max-stale gets increased HOT 2
- Move to go modules for dependency management HOT 5
- Authentication in mt-gateway or document other way to proceed without tsdb-gw HOT 4
- Panic in mt-whisper-importer-reader HOT 1
- Conf parsing changes fail to parse regex HOT 2
- Multiple shards on same hardware node HOT 2
- metrictank memory issues HOT 6
- UnpartitionedMemoryIdx.Get does not check writeQueue
- MetricData messages in mdm topic poorly defined. make versioning explicit?
- Is the project stalled? HOT 2
- Control partition size using Cassandra as backend HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from metrictank.