Coder Social home page Coder Social logo

Comments (6)

bergquist avatar bergquist commented on June 7, 2024 1

I approve of this message.

from grafana-plugin-sdk-go.

marefr avatar marefr commented on June 7, 2024 1

Reason for resources: https://restful-api-design.readthedocs.io/en/latest/resources.html. Route is to me a technical thing and you could register such using the SDK. Due to this I would vote for something else than route. But I really don't care as long as the only thing that changes is the route. I feel currently there are other things more important to focus on.

from grafana-plugin-sdk-go.

ryantxu avatar ryantxu commented on June 7, 2024

This is just a naming discussion -- no functional changes. neither is perfect, but resource is tooo general, and I find the plural api path:

apiRoute.Any("/datasources/:id/resources/*", ...

pretty akward

from grafana-plugin-sdk-go.

kylebrandt avatar kylebrandt commented on June 7, 2024

If we can I would like to see us add Route/Paths to DataQuery as well. If we can do that, this name might be more confusing?

from grafana-plugin-sdk-go.

bergquist avatar bergquist commented on June 7, 2024

I feel currently there are other things more important to focus on.

Now is our chance to make breaking changes to the protobuf files. After 6.7 we have to stick with them FOR EVER :) That said.. even thou I prefer route I'm not sure it's worth the effort. It's not that much better.

For DataQuery I think Paths would make sense and I dont think renaming resources to routes would be confusing.

from grafana-plugin-sdk-go.

ryantxu avatar ryantxu commented on June 7, 2024

i think this ship sailed.... :(

from grafana-plugin-sdk-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.