Debug mode not working in LLM plugin about grafana-plugin-sdk-go

[andresmgot]

When running in debug mode I see an error "address is empty" which seems to be related (I don't see that with other apps):

logger=plugin.grafana-llm-app t=2023-11-02T17:03:36.360031792+01:00 level=info msg="Starting plugin process"
logger=plugin.grafana-llm-app t=2023-11-02T17:03:36.360083469+01:00 level=debug msg=Profiler enabled=false
logger=plugin.grafana-llm-app t=2023-11-02T17:03:36.36011727+01:00 level=debug msg=Tracing enabled=false propagation=
logger=plugin.grafana-llm-app t=2023-11-02T17:03:36.360135526+01:00 level=debug msg="2023/11/02 17:03:36 Error: address is empty"
logger=plugin.grafana-llm-app t=2023-11-02T17:03:36.360159282+01:00 level=debug msg="Serving plugin" plugins="[diagnostics resource data stream]"
logger=plugin.grafana-llm-app t=2023-11-02T17:03:36.360288951+01:00 level=debug msg="plugin address" address=/tmp/plugin1476197245 network=unix
logger=plugin.grafana-llm-app t=2023-11-02T17:03:36.360316465+01:00 level=debug msg="using plugin" version=2
logger=plugin.grafana-llm-app t=2023-11-02T17:03:36.360681938+01:00 level=debug msg="Plugin restarted"

But I am unable to see what's the root cause.

[marefr]

The error seems to originate from here and saying that there's no standalone address set:

grafana-plugin-sdk-go/internal/standalone/standalone.go

Lines 109 to 116 in ebfab9f

	standaloneAddress, err := getStandaloneAddress(pluginID, dir)
	if err != nil {
	return ClientSettings{}, err
	}
	if standaloneAddress == "" {
	return ClientSettings{}, errors.New("address is empty")
	}

[asimpson]

@marefr I'm not seeing an error about an empty standalone address 🤔 I spent a little time tracing through the standlone machinery in the sdk and it seems like the pid and address are created correctly when launching a debugging session.

Also, I'm able to get a breakpoint to pause execution if I put a breakpoint in main.go but any breakpoints further in the plugin, e.g. in app.go, will not pause.

[marefr]

@asimpson where have you put the breakpoint in app,go? If NewApp please note that it will run whenever the first request comes in. You should see the log message "Creating new app instance" when that happens and be able to put a breakpoint there. Let us know if it still doesn't work and we'll try investigate further.

[asimpson]

I put the breakpoint on that message actually but I don't see the message and the breakpoint never fires.

[marefr]

@asimpson I just tested this and works as expected for me. Did use the following steps:

1. Clone the llm repo
2. npm install
3. mage -v
4. mage build:debug
5. Edit custom.ini of Grafana

[plugin.grafana-llm-app]
path = /home/marcus/go/src/github.com/grafana/grafana-llm-app

[log]
filters = plugin.grafana-llm-app:debug

6. Start grafana and configure/enable grafana-llm-app with dummy setting and click Save & test
7. Verify that log messages from plugin are in grafana's server log

DEBUG[11-14|15:26:26] Creating new app instance                logger=plugin.grafana-llm-app
DEBUG[11-14|15:26:26] Loading settings                         logger=plugin.grafana-llm-app

8. Add .vscode/launch.json for plugin

{
  "version": "0.2.0",
  "configurations": [
    {
      "name": "Standalone debug mode",
      "type": "go",
      "request": "launch",
      "mode": "debug",
      "program": "${workspaceFolder}/pkg",
      "env": {},
      "args": ["-standalone"]
    }
  ]
}

9. Set breakpoint at https://github.com/grafana/grafana-llm-app/blob/549bb92516fe7f6836841e82056d565a2e6f29c1/pkg/plugin/app.go#L40
10. VS code start debugging using "Standalone debug mode"
11. Navigate to http://localhost:3000/plugins/grafana-llm-app and click Save & test
12. Breakpoint are hit

[marefr]

Closing this. Feel free to reach out if it still doesn't work and we can re-open