Coder Social home page Coder Social logo

Comments (10)

ryantxu avatar ryantxu commented on May 28, 2024 1

I think yarn could/should call mage, but not the other way around

Any backend linting etc should be in mage -- frontend can handle the whole process

from grafana-plugin-sdk-go.

ryantxu avatar ryantxu commented on May 28, 2024 1

closing since this belongs in toolkit (and is mostly there)

from grafana-plugin-sdk-go.

aknuds1 avatar aknuds1 commented on May 28, 2024

I think it does make sense!

from grafana-plugin-sdk-go.

marefr avatar marefr commented on May 28, 2024

Maybe would make sense to add it to @grafana/toolkit instead since both frontend and backend would find it useful?

from grafana-plugin-sdk-go.

aknuds1 avatar aknuds1 commented on May 28, 2024

@marefr Possibly? Not sure.

from grafana-plugin-sdk-go.

bergquist avatar bergquist commented on May 28, 2024

My assumption is that frontend-only plugins would use the build part of the SDK as well for publishing etc. We should have one user-facing way to package, publish, lint etc plugins imo.

from grafana-plugin-sdk-go.

marefr avatar marefr commented on May 28, 2024

My assumption is that frontend-only plugins would use the build part of the SDK as well for publishing etc. We should have one user-facing way to package, publish, lint etc plugins imo.

Currently scaffolding, building, testing, linting and packaging is implemented in toolkit. I guess the question here is if mage should call yarn tasks from @grafana/toolkit to manage frontend tasks as well? And/or if mage should be required for developing frontend plugins.

Does @ryantxu or @dprokop have any input here?

from grafana-plugin-sdk-go.

ryantxu avatar ryantxu commented on May 28, 2024

My assumption is that frontend-only plugins would use the build part of the SDK as well for publishing etc. We should have one user-facing way to package, publish, lint etc plugins imo.

Toolkit does most of this quite nicely. GEL is the only exception because it has no frontend... it likely makes sense to use yarn to build/package it anyway so that it is not a special flower.

from grafana-plugin-sdk-go.

bergquist avatar bergquist commented on May 28, 2024

Toolkit does most of this quite nicely. GEL is the only exception because it has no frontend... it likely makes sense to use yarn to build/package it anyway so that it is not a special flower.

Yes! We should stick to one process.

I didn't know the toolkit did all this work already. But given that I think we should try to hide mage as much as possible from the user.

from grafana-plugin-sdk-go.

aknuds1 avatar aknuds1 commented on May 28, 2024

Sounds sensible enough for me also to have yarn or grafana-toolkit call Mage.

from grafana-plugin-sdk-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.