Coder Social home page Coder Social logo

Comments (12)

abhisant avatar abhisant commented on August 21, 2024 1

Let me have a look into it.

from druidplugin.

tutunci avatar tutunci commented on August 21, 2024 1

Thanks!
I've manually updated the plugin and now it's working fine.

Thanks a lot!
M.

from druidplugin.

abhisant avatar abhisant commented on August 21, 2024 1

Released:
https://grafana.net/plugins/abhisant-druid-datasource?version=0.0.4

from druidplugin.

emitskevich avatar emitskevich commented on August 21, 2024

I have the same issue. Looks like only topN charts are affected.

from druidplugin.

abhisant avatar abhisant commented on August 21, 2024

I am working out with Grafana team to understand what exactly changed. According to them there is no breaking change in the plugin except the Lodash version upgrade. They have asked for further details, please follow the link below.

grafana/grafana#7581

from druidplugin.

knoguchi avatar knoguchi commented on August 21, 2024

EDIT: it wasn't working actually. It was still using lodash v3. Please disregard this comment.

It works fine for me. I'm using the HEAD of Grafana v4.1.x branch (commit: v4.1.1+2-g46c1f7), compiled myself, and the HEAD of master branch of the druidplugin compiled myself (Thanks for the build script!).

git diff dist has lots of differences. Maybe the checked-in dist files are outdated?

I tested timeseries, topN, groupBy queries. All works.

from druidplugin.

abhisant avatar abhisant commented on August 21, 2024

@knoguchi : It's surprising because even I am seeing the issues in topN and groupBy.

from druidplugin.

abhisant avatar abhisant commented on August 21, 2024

git diff dist has lots of differences - Yes, I have just checked in build related files..

from druidplugin.

knoguchi avatar knoguchi commented on August 21, 2024

Created PR #9 to fix the topN. I noticed my compilation had a problem that I reported earlier.

from druidplugin.

abhisant avatar abhisant commented on August 21, 2024

@knoguchi : Thank you for all the pull's and identifying the issue. Instead of a branch I was thinking to put a git tag, because anyways when I release the grafana version, they take the commitId and all commits before the particular commitId are taken into the consideration. Please let me know if you are ok with creating a tag instead of branch.

from druidplugin.

knoguchi avatar knoguchi commented on August 21, 2024

tag is fine.

from druidplugin.

abhisant avatar abhisant commented on August 21, 2024

Issued a pull request to the Grafana team to release 0.0.3 and 0.0.4. (Release notes at: grafana/grafana-plugin-repository#99)

The fix is available in the dist folder. Till the version is released the dist files can be copied to fix the issues. Thanks to @knoguchi for identifying it and issuing a pull.

from druidplugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.