Druid plugin doesn't work on latest Grafana master about druidplugin

[abhisant]

Hi Cheng, Could you please try cloning the latest changes. There are few fixes that went today morning. Thank you, Abhishek Sant

…

On Oct 5, 2017, at 4:32 PM, Li Cheng ***@***.***> wrote: I built Grafana from master(0c31c7b10619088784bd28b31a4948e43d05d2bf) and installed Druid plugin as usual(putting it under /data/plugins folder), however when I tried to save Druid setting, following error occurred: <https://user-images.githubusercontent.com/3478165/31256932-4df002d8-a9ea-11e7-820b-baf9b76d5144.jpg> I checked Grafana code which says // plugin module needs to export a constructor function named Datasource But in module.d.ts <https://github.com/grafana-druid-plugin/druidplugin/blob/master/dist/module.d.ts>, DruidDatasource is explicitly exported as Datasource, so not sure what happened... please help! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#37>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF098IiP6RoZRghC_1KMQpZB7I_W1ij0ks5spWcPgaJpZM4Pv1jU>.

[chinseone]

Hi Abhishek,

Thanks for your quick reply. I tried latest code, but the error still happened.

Regards,

Li

[abhisant]

@Gauravshah : Is this because of any of your changes. Could you please help @chinseone . Else I can jump in if it's not related to your changes.

[Gauravshah]

@abhisant can you please take a look into it ? stuck for next couple of days

[chinseone]

Hi @abhisant ,

Are you able to reproduce this issue? My environment is:

node 6.9.0/8.6.0, both has same error
npm 3.10.8
Go 1.9

Thanks,

Li

[abhisant]

I will get back to you on this.

…

On Oct 6, 2017, at 12:27 PM, Li Cheng ***@***.***> wrote: Hi @abhisant <https://github.com/abhisant> , Are you able to reproduce this issue? My environment is: node 6.9.0/8.6.0, both has same error npm 3.10.8 Go 1.9 Thanks, Li — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#37 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF098A4auiO9UGj9Xl7SreUM_SsR8S6sks5spn8igaJpZM4Pv1jU>.

[pkarmaka]

I am on vacation currently, will be back in 3days. I can also have a look then. Thanks @abhisant for checking this.

[chinseone]

Hi @abhisant , just wanted to follow up on this issue. Any updates?

[abhisant]

@pkarmaka could you please look into it

[pkarmaka]

@chinseone which grafana version are you using

[chinseone]

@pkarmaka I built from master commit(0c31c7b), which was "4.6.0-pre1"

[pkarmaka]

Not sure exactly what but something may have changed in the Grafana master code. If you try 4.5.2, that's working.

[chinseone]

Do you think it's a plugin issue or Grafana's problem? If the later is the case, their next release will break stuff :(

[abhisant]

@pkarmaka : Can you check with the Grafana team? May be raise an issue or a query.

[nikhil2406]

@pkarmaka you are right. I checked grafana commit history, there seems to be some changes pushed related to systemjs and webpack module loading. I got same error in grafana tag 'latest' and '4.6.0-beta1'
Druid plugin is working fine with grafana 4.5.2.

[daniellee]

This should be fixed in the latest Grafana master. We upgraded SystemJS which broke the import syntax for some plugins. We changed the SystemJS configuration and the Druid data source should work now.

[chinseone]

Thanks @daniellee and everyone for fixing this!

[iamsurya-dev]

Thanks guys!