Coder Social home page Coder Social logo

Comments (24)

abhisant avatar abhisant commented on August 21, 2024 2

@nanittu : @nikhil2406 and @pkarmaka issued a pull, it was reviewed / merged and tested. The feature is present in the repo, you can copy the dist contents and update your plugin. I will release it soon as a part of Grafana plugin.
Please let us know if you face any issues.

from druidplugin.

abhisant avatar abhisant commented on August 21, 2024

Could you please elaborate ? Didn't completely follow you.. Which html are you referring to .

from druidplugin.

knoguchi avatar knoguchi commented on August 21, 2024

Your src/partials/query.editor.html has Aggregations section but missing Post Aggregations.
@godfreyhe 's original has both Aggregations and Post Aggregations.

from druidplugin.

abhisant avatar abhisant commented on August 21, 2024

Ok. Thanks. I will have a look into it.

from druidplugin.

knoguchi avatar knoguchi commented on August 21, 2024

I modified the html. Arithmetic type worked with a bit of fix in JS. Quantile type didn't work but didn't investigate.

from druidplugin.

abhisant avatar abhisant commented on August 21, 2024

ok, thanks. This repository is currently under review by Grafana team. Once that is done and the plugin is available on grafana.net, I will add the changes you requested.

from druidplugin.

abhisant avatar abhisant commented on August 21, 2024

@knoguchi : The plugin is avaiable on grafana.net now.
Do you want to issue a pull request of the changes that you already made. Else, I will make those changes and debug the "Quantile type" issue.

from druidplugin.

rzarajczyk avatar rzarajczyk commented on August 21, 2024

Hi, what is the status of this issue? Will you merge those changes?

from druidplugin.

knoguchi avatar knoguchi commented on August 21, 2024

My fork has diverged a lot for my own needs. Query editor UI is different, resulting configuration data structure is different (not compatible with Abhi's). So it's not mergeable.

from druidplugin.

rzarajczyk avatar rzarajczyk commented on August 21, 2024

thank you

from druidplugin.

abhisant avatar abhisant commented on August 21, 2024

Sorry for the late response. I am currently traveling out of the country for a month, (on vacation with intermittent internet connectivity). I will try to find some time out of my vacation to add the build scripts.

from druidplugin.

PanYifeng avatar PanYifeng commented on August 21, 2024

Hi, Can anyone tell me when could druidplugin suppert Post Aggregation feature?

from druidplugin.

nanittu avatar nanittu commented on August 21, 2024

Is there a rc version this is merged into ? we are very interested to check this for our use case any details would help us.

from druidplugin.

abhisant avatar abhisant commented on August 21, 2024

@knoguchi are you planning to merge this ?

from druidplugin.

knoguchi avatar knoguchi commented on August 21, 2024

Sorry, no plan. As I mentioned in this thread, my fork has diverged significantly.
The filters, aggs and post aggs has changed to support math expression than the single field dropdown. On top of that, I'm moving on to SQL queries for Druid 0.10.

from druidplugin.

abhisant avatar abhisant commented on August 21, 2024

@PanYifeng I will try to add this or someone from my team will work on this and add this feature soon.

from druidplugin.

nanittu avatar nanittu commented on August 21, 2024

@abhisant any update on the feature addition ?

from druidplugin.

pkarmaka avatar pkarmaka commented on August 21, 2024

I and @nikhil2406 have just started working on this. Will get back to you on the ETA soon.

from druidplugin.

abhisant avatar abhisant commented on August 21, 2024

Thanks @pkarmaka and @nikhil2406.

from druidplugin.

nanittu avatar nanittu commented on August 21, 2024

@pkarmaka any ETAs on this ? Sorry for the push. we are on the brink of making a time sensitive product decision.

from druidplugin.

pkarmaka avatar pkarmaka commented on August 21, 2024

@nanittu ETA is around 25th-29th June..

from druidplugin.

nikhil2406 avatar nikhil2406 commented on August 21, 2024

@nanittu we have completed this change and currently in process of verifying it. We'll sending out pull request soon.

from druidplugin.

abhisant avatar abhisant commented on August 21, 2024

Thank you @nikhil2406 @pkarmaka for quick turnaround.

from druidplugin.

nanittu avatar nanittu commented on August 21, 2024

@abhisant @pkarmaka @nikhil2406 Thank you ! appreciate your timely response.

from druidplugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.