gpolguere / path-to-regexp-php Goto Github PK

View Code? Open in Web Editor NEW

22.0 3.0 5.0 13 KB

PHP port of https://github.com/pillarjs/path-to-regexp

License: MIT License

PHP 100.00%

regexp php regular-expression regexp-special-characters routing route path

path-to-regexp-php's Issues

Composer-ify it?

https://getcomposer.org/

Would be better than having to copy/paste it around.

::match examples error

Looks like the examples in the readme show $matches as the 3rd argument:
https://github.com/gpolguere/path-to-regexp-php#named-parameters

However, in the code, it looks like ::match returns $matches and does not accept a third argument:
https://github.com/gpolguere/path-to-regexp-php/blob/master/src/PathToRegexp.php#L149

[Bug]If the parameter appears in the middle, there will be a problem

$keys = [];
$re = PathToRegexp::convert('/user/:id/avatar', $keys);
PathToRegexp::match($re, '/user/12345/avatar');

At this time, $Keys will be repeated twice

array(2) {
  [0]=>
  array(4) {
    ["name"]=>
    string(6) "id"
    ["delimiter"]=>
    string(1) "/"
    ["optional"]=>
    bool(false)
    ["repeat"]=>
    bool(false)
  }
  [1]=>
  array(4) {
    ["name"]=>
    string(6) "id"
    ["delimiter"]=>
    string(1) "/"
    ["optional"]=>
    bool(false)
    ["repeat"]=>
    bool(false)
  }
}