gothick / omm

Hi, I’m @gothick. I'm a random geek from Bristol, England. I've been programming for about forty years. I'm very much a jack-of-all-trades style generalist, often picking up a technology, doing some odd project in it, then moving on to something completely different.

As a day job I'm a data engineer mostly on the Microsoft SQL Server/Azure platform; in my spare time I'm now developing for Android or iOS or using (modern, usually Symfony-based) PHP on the web, sometimes adding JavaScript in whatever framework happens to be popular that Tuesday.

Along the way I've gotten good enough to hold down paid jobs using C, C++, C#, Visual Basic, PHP, JavaScript, Java, Objective C, Oracle PL/SQL, XSL, Python, SSIS, SSAS, Informatica ETL, and probably a few more things I've forgotten. I've basically become That Guy Who Knows A Bit About Everything, which I've found to be a pretty useful role, especially on smaller, fast-moving teams.

omm's Issues

Improve gallery layout on Wander page

Brainstorm some ideas.

Add mini-map to image page

Add a mini-map to each image page showing where the image was taken (and optionally the wander it was taken on) zoomed in so you can see just the detail around the snapping point.)

Tidy up public image page header

It's got a lot of good info but it needs more separation/a bit more visual hierarchy. Re-read Don't Make Me Think?

Add wander names to next/previous buttons on wander page

(maybe within a span that only shows on wider pages)

Why is the wander duration one second on the dashboard when there aren't any wanders?

Bug: if you don’t have any wanders, your total wander duration seems to be displayed as 1 second on the homepage. Why is that?

Feature: Support for Twitter Cards on Image pages

From what I remember, it's not that hard.

Add menubar search box

Testng #test

Image and Wander Descriptions (and Titles?) should allow superscript HTML element

Tags we should allow on top of markdown:

• sup
• hr

It's possible that something like this Purifier bundle that already includes a twig filter and easy-looking configuration could work well.

Wander popup may not be sanitising input properly

Your Twenty Lorem <span style="color: red">Seventh</span> Floople test wander has the red come out in the popup from the front page map when you click on the wander path.

Make edit link on public Wander and Images pages consistent

When you're logged in as admin, viewing the public Wander and Image pages, there's a link to edit them in the back-end. On the Wander page, it's a text link on the left-hand side below the Description; on the Image page it's a button on the right-hand side below the description. Pick a location and a look and stick to it!

Improve Keyword/Tagging System

Add links to all tags that link to a tags page, that displays all images with that tag, paginated. This will probably mean rewriting the way tags work; we don’t want them in an array any more; they’ll have to be split into their own table. There’s a nice-looking package here for that: https://github.com/Bee-Lab/BeelabTagBundle/blob/master/docs/index.md

Add loading spinner to front page (or speed it up somehow!)

Something like this, i.e. using jQuery's when might be appropriate, but I don't know how easily it'll plug into the third party stuff we're using.

Multi-word Tags/Auto Tags seem to wrap and get tall for some reason

e.g. on https://omm.gothick.org.uk/image/5346 I see:

Feature: Support for Twitter Cards on Wander pages

Similar to #49, but probably needs #25 (Featured Images) completed first to be worth doing.

Centre all knpPaginators

Might even be able to do it by setting a default option in the config. But anyway, it's an option and you're already successfully using it in the public Wander page image paginator.

Add credits page

• Including Bristol Open Data
• geotools2.js
• Possibly just add it to the About page, with a configurable section?

markdowntoplaintext Filter Shouldn't Encode Entities

Our markdown_to_plain_text filter is a bit too simple: I think we're outputting encoded entities, i.e. Rod & Ruby's is coming out as Rod & Ruby's where it should just be left plain and simple. The fact we're pre-encoding means that Twig is double-encoding, so we end up with & shown on the page. This isn't dangerous, but it's a bit messy and may also be slightly affecting search indexing.

Repro: Create wander with description Rod & Ruby's. View /wanders index page.

It's time to update dependencies

Run “composer update” & test

Bug: Deleting and re-uploading a Wander with many images times out

Repro:

1. Create a wander with many images (e.g. 28 March 2021 wander with 81 images)
2. Delete the wander, leaving the images
3. Re-upload the Wander

This will produce: Error: Maximum execution time of 30 seconds exceeded

I think it's likely to be the cumulative time taken re-adding the images to the wander, given that for every image, I think we'll be recreating the Elasticsearch index for every image added to far up to that point. Certainly the Elasticsearch process seemed a bit busy when I saw this. A wander with only 12 images was quite quick.

Upgrade deployer/deployer once they're out of beta

Downgrade composer requirement away from beta versions for deployer/deployer when the project has stabilised

Make map pop-up images responsive

Responsive Images: add sizes to images in poups on maps. You have notes in Notion https://www.notion.so/gothick/OMM-Responsive-Images-c1a45c69bde54217bb61113aa2c934f1

Make a public-facing stats page

Can we make the tracks a little thicker to ease clicking on them?

Deprecation

see https://scrutinizer-ci.com/g/gothick/omm/issues/master/files/src/Service/StatsService.php?selectedLabels%5B0%5D=11&selectedSeverities%5B0%5D=10&selectedSeverities%5B1%5D=5&orderField=path&order=asc&honorSelectedPaths=0&issueId=46427322#inspectioncomment-169290526

Fix these minor Scrutinizer warnings

https://scrutinizer-ci.com/g/gothick/omm/issues/master/files/src/Service/DevGoogleImageTaggingService.php?selectedLabels%5B0%5D=9&orderField=path&order=asc&honorSelectedPaths=0

Create a "Featured Image" feature?

• Would you just choose one image from the wander?
• Test what happens if you delete that image. Does it break the wander?

• Add flag to Image for "show in wander?"
• Add featured image ID as property of Wander
• Filter out non-shown images from everywhere we display wanders (probably includes API)
• Add UI to allow setting/viewing featured image
• Add UI to allow setting/viewing "show?" flag
• Show featured image on front-end in appropriate places; bare minimum is main Wander show page
• Add featured image to RSS feed
• Add tests for various scenarios as we go/practise a bit of TDD

Tidy search Twig template

Consider adding a comment system

Is disqus still going?

Javascript shouldn't have hardcoded home-base co-ordinates

You could pass co-ordinates (from your existing app.homebase_coords parameter) through a method like this.

Downgrade friendsofsymfony/elastica-bundle to a non-dev stability requirement

Downgrade friendsofsymfony/elastica-bundle to a non-dev stability requirement in Composer once 6.0 is out of beta/dev

Make your auto-tags searchable

• Needs lower search result influence than other fields
• Make it optional?

Add a method of redetecting auto tags from the front end

Add wander details on track popup, including Featured Image

Message Consumers Aren't Restarted by Deployer Deployment

We're basically being affected by this bug: symfony/symfony#40477 (comment)

At some point, we should try the workaround provided.

Add map key for latest wander.

Add a key for “most recent wander”. Maybe change most recent wander colour? Have different colours for latest/currently selected?

Add a new type of image for third-party images like historical images

Add a new kind of image: it has a “source” field and and URL and time/date and displays differently so I can show other people’s/historical photos better. This would also allow me to put a blanket copyright message/licence restriction on any of my pictures.

Write unit tests for Exifhelper

Remove old image URL redirect

Now we've fixed all the links, should remove oldImagesShowRedirect from the image controller.

Add keyword search

Best to wait for #4 to be done first.

Add footer

At least have a direct link to your Twitter and gothick.org.uk

Rewrite Tagging Again

Using BeelabTagBundle seems to be overcomplicated and needs some strange workarounds. It feels quite fragile. I think we should simply re-do tagging from scratch, implementing it manually ourselves.

Tidy Search Controller

Fix sort order of images on admin images index page

They're in date order, but should also be sorted by id descending secondarily, so the most recent upload always appears last, even if it's another copy of the same image.

Feature: Make latitude/longitude optional on Image Edit page

Probably not every image needs a latitude/longitude, and even if one is missing, it's irritating to have to find one rather than just put the absence on a "to-do" list when you're trying to edit something else. And it's optional in the database.

Make admin interface images responsive too

Responsive Images: add sizes to images in admin interface. You have notes in Notion https://www.notion.so/gothick/OMM-Responsive-Images-c1a45c69bde54217bb61113aa2c934f1

execute() is deprecated.

see https://scrutinizer-ci.com/g/gothick/omm/inspections/eb06c0d0-7c68-43f4-b402-29a892994d2f/issues/files/src/Service/StatsService.php?status=new&orderField=path&order=asc&honorSelectedPaths=0&issueId=46486640#inspectioncomment-169983103

Add other walk statistics to public wander page. Walk length, etc.

• Number of Images
• Distance
• Duration

This could also be a good time to make the Wander page look a little more like the slightly-prettied up Image page.

If you make the admin Edit links consistent at the same time you could close 64.

Move .htaccess config to main server config

Consider moving the .htaccess stuff provided by the apache bundle into the main apache config file for omm

Remove LuckyController.php