gossips / earlywarningsignals Goto Github PK

elif spline == True:

371 |   | f = interpolate.splrep(x = x, y = df[y].tolist(), k = k, s = s)
372 |   | i = interpolate.splev(x = new_x, tck = f, der = der)
373 |   | df_new[y] = i

It is advisable to not compare floats directly as, for instance:

f1 = 0.123456
f2 = 0.1234567

# Assert equal
assert(f1 == f2)

>>> FAIL

It is safer to define a numerical tolerance:

f1 = 0.123456
f2 = 0.1234567
tol = 1e-4

# Assert almost equal
assert(f1 == pytest.approx(f2, tol))

>>> SUCCESS

The file setup.py should contain information about the author(s) of the code. Right now, it doesn't.

Suggested action

Add at least one email and one name in the file. The url is also wrong, update it to the current repository.

In order to try the continuous integration systems, I needed to have all tests in good shape.

One of them was failing, so I killed it in commit 5da80e3

Suggested actions

1. Revert the commit
2. Fix the test / the function

test_EWS() is failing since, at least, commit b8d5f11

Strangely enough, the tests work fine when running locally.

To add even more mystery, Travis also failed after re-running the successful commit d6216ff