Coder Social home page Coder Social logo

lesti_fpc's People

Contributors

alexherbs avatar aurmil avatar davidwindell avatar erfanimani avatar erikhansen avatar firewizard avatar gordonlesti avatar lshchur avatar mat-b- avatar matthew-muscat avatar nussjustin avatar nussjustin-hmmh avatar paulpartington avatar rafaelpatro avatar rikwillems avatar schumacherfm avatar sprankhub avatar therouv avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

lesti_fpc's Issues

Community Poll - not working

Magento CE 1.9.0.1, FPC::Lesti is caching Community Poll I guess because when I vote the side block remains unchanged, ready for another vote, but not showing any results.

I need a solution to skip caching for Community Poll side block. I can keep Polls hide for a while, but not too long. Thank you.

add an option for flush the cache of concret url

Hi!

This is a suggestion for add an option in the admin panel for flush the cache regarding about concret url.

This method is used in CDN like cloudflare, and is very good for only delete the cache related for example with one product or one cms, and no need to delete the previous cached products/cms, etc.

thanks.

Clean cache for a specific product after it has been purchased

We are showing delivery time on product pages based on inventory level. This is ofcourse cached. After a product is saved in backend the cache gets refreshed correctly so the data in frontend is correct.

But if the product is purchased the cache is not refreshed. Is there a way to force a refresh on productpages after they have been ordered? There is an method for clearing the cache allready.

catalogProductSaveAfter, this refreshes cache, it is fired trough this event: cataloginventory_stock_item_save_after

Possibility to ignore block types

Related to #11.
One way to go around this would be the possibility to ignore block types. The block name ignore feature doesn't help since they can be user generated on my website.

Rendering always the same block on catalog_product_list

Hello,
i am using better_configurable_products swatches on my product_list added to product_list in my local.xml. The block (product.info.swatches) is working completely correct when used without lesti_fpc
$this->getLayout()->getBlock('product.info.swatches')->setProduct($product)->toHtml() is called in the template and it works like a charm (setProduct() sets the cache-key according to the acutal product).

The Problem now is, that with lesti_fpc, the setProduct() seems to be ommited, even if i enter the blockname to the dynamic-block-list in the backend.
Do i get it right, that the cache is looking for the block by name and delivering it before even setting the product and my idea to have it as dynamic block is not that clever because even dynamic blocks are only rendered once per page load?

hashed_directory_umask' is deprecated

I'm getting a lot of these warnings in the system.log:

2014-05-26T08:29:13+00:00 ERR (3): User Notice: 'hashed_directory_umask' is deprecated -> please use 'hashed_directory_perm' instead in /lib/Zend/Cache/Backend/File.php on line 144

Layered Navigation won't work with FPC turned on.

Hi Gordon,
Really like you work and wanted to know if I need to "enable" something in the backend in order to get the layered navigation working?

Issue is that the actual filtering is not functioning.

Tested on Magento 1.7.0.2. on the default theme.

Thanks.

Minification of html code

It would be nice, if the extension also minified the html code. It is good for page speed and little bit for SEO

Message block appearing after content home page

Hi Gordon,
I have installed your fpc with Ajax extension.
But not the messages block is showing below the home page content instead of at the top after_body_start position.

Any ides why? Or how to solve? Thanks

Regenerate the FPC when logged in?

I have a few blocks which change when the user is logged in, alas FPC doesn't recognize that event and outputs the cache as generated at 1st access.

ajax.phtml not valid template

Hi Gordon,

Have a 1.7.0.2 site running the latest Lesti_Fpc backed by redis/cm_cache_backend_redis. It's raising the error

2013-08-27T20:55:13+00:00 CRIT (2): Not valid template file:frontend/base/default/template/fpc/catalog/product/view/ajax.phtml

in var/log/system.log.

File is unchanged by us. Should I be worried?

Cheers,

Steve

Support glob or regex in uri params

It would be great if lesti_fpc had support for glob or regex in uri params. I'm using a layered navigation module which uses uri params like 'filter_size' and 'filter_color'. If you don't want to update the cache configuration when adding a new attribute or just have dozens of them, adding one pattern to match them all would be great.

auto-update product stocks

Thanks for share your work!

I am showing the real stock in numbers in the frontpage.

I have a custom develpment extension that show the stock of all the combinations in a configurable product. In concret are t-shirts with differents color/sizes, and when you click in any color, appear the disponibility quanty of each size of this color.

I was tried to modify the stock in one simple product assigned to a configurable product, but still showing the old stock because is cached too.

Mabye you can add an option for auto-refresh the information in the cached files regarding about the stocks when was changed in any product.

thanks!

Extension doesn't improve response time

I have two magento shops (v. 1.6, both are configured almost exactly the same way and use the same plugins). In your extension has a big impact and I get server response times of about 500ms.. On the other shop, I can't notice any difference. The page load time varies between 2 and 3 seconds.

I have enabled the FPC cache under System | Cache management. Other than that, I haven't changed any configuration. I also looked into the var/cache folder and fpc--xxx folders get created. Do you have any idea what the reason for this behavior might be?

global_messages vs messages issue

Me Again, Gordon,

Line 74 in Observer.php

$blockName = $blockName == 'global_messages' ? 'messages' : $blockName;

Is forcing the placeholder for global_messages to be "messages". So, when we subscribe to the newsletter, it's coming through as a global_message and there's no placeholder for it and so it does not get replaced. By removing this line, the global_messages placeholder is maintained in the FPC and so the replacement works correctly and the newsletter subscribe message is shown correctly.

My question is, what was the purpose of forcing global_messages to be messages?

Using Lesti_Fpc with Memcached fallsback to file

I am currently experiencing a problem where Lesti Fpc is falling back to file eventhough the memcached server is up & running. I have enabled debug but do not see any results from this anywhere.

Currency Switcher doesn't work for cached pages.

Hi Gordon,

I'm seeing issues with the currency switcher being applied. The "cart" is updated because that's a dynamic block. If I apply it as a "dynamic block" (it should really only affect the switcher anyway), the currency switcher disappears but the prices are not switched.

I think we'd need to catch a currency switcher event and clear the cache. Hopefully, I can spend more time looking at it tomorrow.

?___SID=U added to random URLs

On our development server when FPC is enabled some link urls have ?___SID=U randomly added to the end.

To create the issue we navigate around the site and within a short time the problem will occur. It seems to randomly effect urls that are automatically generated i.e toplinks like account login and related product links. Refreshing the page by pressing F5 will fix the URLs

Disabling Blocks HTML output in Cache Storage Management fixes the problem, but obviously we would rather not leave this disabled permanently.

Customer rating on products page

(not a real issue, nut maybe an idea for further improvement)

Hi, today I noticed that customer ratings on product pages (the stars) are cached and not updated through dynamic or per customer basis.

Is there a way to flush the cache one ratings get approved in the backend (resulting in a page update)? Or make it lazy per default?

Error notice Lesti_Fpc 1.0.2

Hello Gordon,
I've 1 error and 1 warning in the log files.
ERR (3): Notice: Undefined property: Lesti_Fpc_Model_Fpc::$_disallowSave in /public_html/app/code/community/Lesti/Fpc/Model/Fpc.php on line 48
httpd: PHP Fatal error: Call to a member function asArray() on a non-object in /app/code/community/Lesti/Fpc/Model/Fpc.php on line 27

Best Regards, Paul

Comparing product doesn't work (Magento 1.8)

Hi,

I just installed your extension, and I have to say it's really great. I was previously using Varnish + a custom ESI mechanism but it was too complicated to adapt after the upgrade to community 1.8 because of the introduction of form keys on the frontend.

I'd like to know how I can debug my custom template to find why the URLs like

/catalog/product_compare/add/product/26456/uenc/aHR0cDovL2Rldi5sZXBhcGUuY29tL3NhbG9tb24tcy1sYWIteHQtNi1zb2Z0Z3JvdW5k/

don't work when I'm in a different session from the one who cached the page first.

Thanks!

Magento mini cart on top issue

Hi, all, I m having issue with mini cart on right top of my template which does not stay dynamic, i.e, FPC caches it. When product is added, it changes, but when I go back to homepage, homepage does not reflect the items, this is happening with all the pages, i.e, minicart status of that particular page does not carry forward to next page, be it homepage or any other page. Please help how to solve this.

Bulk updating product attributes in admin doesn't trigger a cache refresh

Hi guys,

Came across this issue while working on a client's site.

Bulk updating products through the admin panel doesn't currently trigger a cache refresh. ie: bulk updating products to become 'in stock' will result in FPC still showing out of stock on the product & category pages.

Mass action updates don't fire the standard catalog_product_save_after event, however we do have a few events that we could use...

Looking at the core events, i can see catalog_product_attribute_update_before is called before the update is made, this has the product ids to be updated

Unfortunately, there isn't an 'after' event that provides the product ids, however we should be able to refer to the event end_process_event_catalog_product_mass_action and process the previous event details.

ref: http://magento.stackexchange.com/questions/9067/catalog-product-save-after-event-for-massaction

Different TTL for Cachable actions

I would like to suggest an implementation of a config to specify different cache TTL for specific cachable actions.
For example the cms_index_index (homepage) could have a shorter TTL than the catalog_product_view.
Thanks

Persistent cart and clossing session

With Lesti_FPC and persistent cart enabled, when you try to close session is not working very well and stay showing the prices of the customer group of the previously logged user instead of the "not loggued in" user.

With persistent cart, normally appear a top message that say "¿not be "name"? and if you click appear the normal prices, but with fpc enabled don't appear. Sometimes appear, but when you click it, dissapear this link but still loggued.

The option for exit the session don't appear more.

Disabling fpc or disabling persitent cart work all ok. Actually we have disabled the persistent cart and works perfect.

fpc.xml defaults to read only

Thanks for the great product

We have to set fpc.xml to our hosting settings, but we cannot edit/write to the default installed files via modman clone

Is this correct?

Issue in top links

Hi Gordon

Can you take a look on http://penelopeestilosa.com ?

I use Apptha´s Social login and FPC 1.4 (for about 1 year) and when you login the top links aren´t refreshing. For example try to logout or my account and it will still shows social login lightbox.

I use top.links as dynamic block in FPC admin options ? Is it correct ? How to fix this issue ? Currently I have to disable FPC to work fine.

Thank you and congratulations for FPC!!!

Cache storage becomes HUGE.

Seems LestiFPC doesn't clean up the cache storage.
After LestiFPC killed my 2GB instance of Redis i decided to try a different storage (to file) and... to my surprise the cache directory keeps growing.
Once it reached 28GBs and i'm forced deleting the cache folder with a cron job.
I guess it's a bug.

Magento Community 1.7.2 - "No Product to Compare"

Hi Gordon,

I've tested many FPC's but your goals fit with what I'm looking for in an FPC - ie: little or no Ajax and no Varnish requirement

Compared Products block only working when user is logged in. When logged out, "No Products to Compare" - messages for this block are working and if you add something and then either turn the cache off or login, it also shows.

AJAX Mime type is text/plain but should be remembered as original type

Not sure if related to #45 but...

Another magento plugin, Catalin SEO, does some AJAX requests, which I are being cached by your plugin.

Problem is, when they are loaded from your cache, you are sending it as text/plain which is crashing the js that receives it.

For the cache misses, it works, and is sent as application/json correctly.

Wondering how I could either blacklist Catalin SEO ajax thing from being cached, or whether your plugin could be extended to remember the mimetype when re-sending.

Thanks

Serialize/Unserialize

Hey Gordon,

Sorry for asking but what is the exact reason for using serialize and unserialize
here and here ?

You only have two entries in that array which can be refactored to e.g.

$fpc->save(time().$body, $key, $this->_cache_tags);

and

$object = $fpc->load($key)
$time = (int)substr($object,0,10);
$body = substr($object,10);

There are many results on google explaining the poor performance of serialize ...

Or if you would still like to use serialize() or json_encode then at least create a fallback to https://github.com/igbinary/igbinary which is overall faster than those previously mentioned methods ...

If you think this issue sucks ... just close it otherwise I can send you a PR 8-)

Cyrill

Honor Cache Lifetime

Currently the lifetime is always "null", which translates to "infinite lifetime". See my commit: novalis111@74cb8c2

I couldn't create a pull request because of other code changes, sorry.

Problem loading images after flushing cache

With the latest version of the module i experience an issue with the product images when viewing an category.

After flushing the cache all images dissapwar on the website. Flushing/refreshing it again, restarting nginx, php-fpm, redis won't help to solve the issue. Only way to get the images back is disable the FPC cache, flush everything and then turn the FPC back on however the problem will appear next time the cache has been flushed.

Anyone else having this issue or am i the only one?

Caching issues with Mobile Themes

When running dedicated mobile themes (tested with aw_mobile and Magento 1.7 native), whichever page is loaded first; Desktop version or Mobile version is then displayed by the FPC to end users for that page.

I've managed a rudimentary workaround on the awmobile version by calling one of their functions

Mage::Helper('awmobile')->getTargetPlatform() and only load / apply FPC if it is the desktop version.

Haven't yet had time to take a look at the Magento 1.7.2 theme yet.

Suggestion: auto-crawler

I think that is good to have integrade in Lesti_Fpc an auto-crawler that continuosly is caching the website, something like if a bot load the web and is the cache was refreshed for the crawled products automatically.

Obviously this crawler need to have something for avoid the server is full all time. Something similar to this:
http://ecommerce.brimllc.com/cache-warmer-for-magento.html
or this:
http://www.extendware.com/full-page-cache-crawler-magento-extension.html
thanks!

Full page cache and different tax rates

Hi Gordon,

I noticed an issue with your implementation. We have multiple tax rates, so the catalog prices change depending of the shipping address of the currently logged customer.

When this happens, if a page is not already cached, it will be stored (obviously) but this lead to pages with different prices tax rates.

Any pointers on how I could implement a check against the currently logged customer, or add a tax rate parameter in the URL hash?

Catalog Price Rules compatibility

The problem goes to Catalog Price Rules. Long story short, when FPC is enables everything works perfectly, all pages are cached and no problem, but when Catalog Price Rules is active and automatically change the price (crontab) the old price still cached in catalog. End when the client is looking at the catalog – they see cached prices (old ones) instead of real ones. But when they add products to cart the real price reveal itself (which is different). Is there is a way to flush a cache when Catalog Price Rules are in action?

Attribute Filter is not workin g on frontend

Hi
I have installed the extension, when I enabled the extension then frontend layered filter is not working,
after disable the extension frontend layered filter is working,
Can you please let me know the solution of this issue?

Thanks
Vishal

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.