gorankarlic / ok-redis Goto Github PK

In case of using
const client = await Redis.connect(opts);
RedisClient.connect will return a Promise to the Redis.connect function which ignores the promise and just proceeds to return the client instead of a promise that would return the client. Thous any error that occurs during the connect will throw an UnhandlePromisRejectionWarning and keeps the app dangling.

class Redis
{
    ...
    static connect(opts = new RedisOpts(), done = void null)
    {
        const client = new RedisClient(opts.opts);
        client.connect(done); 
        return client;
    }
    ...
}

class RedisClient extends Commands
{
    ...
    connect(done)
    {
        if(done === void null)
        {
            return new Promise((resolve, reject) => this._client.connect((err, result) => err === null ? resolve(result) : reject(err)));
        }
        else
        {
            this._client.connect(done);
        }
    };
    ...
}

There seems to be some index(?) issue somewhere in the cluster command processing.

I get a couple of error of these kinds:

RedisError: ERR unknown command bkt:-72:-396, with args beginning with:
at processTicksAndRejections (internal/process/task_queues.js:85:5) {
name: 'RedisError'
}
Edit: bkt:-72:-396 should be the key here, not the command.

RedisError: ERR unknown command 1, with args beginning with:
at processTicksAndRejections (internal/process/task_queues.js:85:5) {
name: 'RedisError'
}

RedisError: ERR Protocol error: expected '$', got ' '
at processTicksAndRejections (internal/process/task_queues.js:85:5) {
name: 'RedisError'
}

RespReader.js class BulkString under some circumstances tries to call toString() on this.r = null.

class BulkString extends Bulk
{
    ...
    result()
    {
        return this.r.toString();
    }
}

return this.r ? this.r.toString() : null; does the job.