googlemaps-samples / codelab-maps-platform-101-js Goto Github PK

I got a compilation error trying to run on Node v18. It appears related to this: https://stackoverflow.com/questions/69692842/error-message-error0308010cdigital-envelope-routinesunsupported

I ran the following cmd line: export NODE_OPTIONS=--openssl-legacy-provider

and it compiled. Unsure if webpack should be updated?

    loader.then(() => {
      console.log('Maps JS API Loaded');
    });

there should be

    loader.**load()**.then(() => {
      console.log('Maps JS API Loaded');
    });

There is a mistake on line 25, page 5 of Add a map to your website (JavaScript)

loader.then(() => {
   console.log('Maps JS API loaded');
   const map = displayMap();
});

It should be:

loader.load().then(() => {
  console.log("Maps JS API loaded");
  const map = displayMap();
});

In this sentence,
"API를 로드하려면 Loader 인스턴스에서 load()를 호출합니다. JS API 로더는 API가 로드되어 사용할 준비가 되면 확인되는 프로미스를 반환합니다. 다음 스텁을 추가하여 API를 로드하고 프로미스를 처리합니다."

I think '스텁' should be -> '스텝'.

loader.then > loader.load().then

Hi,
There should be some minimum average time to complete any step that will be very useful to track a developer if its going with reading/understanding the content. if it's not happened then the steps color should not be change into blue which will help exactly to prevent false badge availability or its value.

I Think, The above logic might be applicable for other Codelabs tutorials.

Hi, @amuramoto !!! I hope you are great!

I found some errors in the Codelab texts and code blocks here https://codelabs.developers.google.com/codelabs/maps-platform-101-js/index.html I will group here in this issue but let me know if you want me to raise separately.

1. Here: https://codelabs.developers.google.com/codelabs/maps-platform-101-js/index.html?index=..%2F..index#2
   in step 3, At the last block of code, there is an unused variable that got as a parameter in the function loadMapsJSAPI for no reason.
   See attached image:

2. Here: https://codelabs.developers.google.com/codelabs/maps-platform-101-js/index.html?index=..%2F..index#5
   in step 6 at the 2 and very last block of code, there is a missed colon there, see attached:

3. Here: https://codelabs.developers.google.com/codelabs/maps-platform-101-js/index.html?index=..%2F..index#4
   in step 5 at the run app function, the console.log disappeared and then it appears in the next steps.

4. Here: https://codelabs.developers.google.com/codelabs/maps-platform-101-js/index.html?index=..%2F..index#5
   At the clusterMarkers function, the markerCluster variable is unused, maybe we can clarify there is no reason for used here but if we can to change in further steps or other functions that reference is important!

I can help you to fix it if you give me access to the source of the codelab!

Cheers!