googlecodelabs / amp-pwa

These are the resource files needed for the Progressive Web AMPs code lab from Google.

Your Progressive Web AMPs Code Lab

These are the resource files needed for the Progressive Web AMPs code lab from Google.

This is a work in progress, if you find a mistake, please file an issue. Thanks!

What you’ll learn

• How to transform an AMP Canonical site into a Progressive Web App
• How to enhance the experience using the AMP pages as a base for an App Shell.

What you’ll need

• A recent version of Chrome.
• Node.js
• The sample code
• A text editor
• Basic knowledge of HTML, CSS, JavaScript, and Chrome DevTools

amp-pwa's Issues

404 Error

I can't open the link to " several caching strategies " ->https://googlechrome.github.io/sw-toolbox/api.html#handlers which is in the Tipp Box of https://codelabs.developers.google.com/codelabs/amp-in-pwa/#3

migrate sw-precache to workbox

sw-precache is deprecated in favor of workbox.
See https://github.com/GoogleChromeLabs/sw-precache

It would be nice if this Codelab would use workbox.

manifest generator not

When going through the Progressive Web AMPs Codelab https://codelabs.developers.google.com/codelabs/amp-in-pwa/index.html?index=#4

I encountered problems generating a manifest.json file using the App Manifest Generator @ https://app-manifest.firebaseapp.com/

After filling in the manifest values and uploading the icon as instructed. I downloaded the zip file and extracted the manifest.json file which I then added to the root of my work folder.

But when I inspected the manifest.json file in my code editor this was all I saw.

{
"icons": null,
"splash_pages": null
}

There were also no image icons generated, Just a manifest.json file.

Those were the only values in the manifest.json generated by the Generator. Could this be an issue with the App Manifest Generator?