Coder Social home page Coder Social logo

googlechromelabs / picture-in-picture-chrome-extension Goto Github PK

View Code? Open in Web Editor NEW
658.0 32.0 151.0 256 KB

Home Page: https://chrome.google.com/webstore/detail/hkgfoiooedgoejojocmhlaklaeopbecg

License: Apache License 2.0

JavaScript 95.17% HTML 4.83%

picture-in-picture-chrome-extension's Introduction

picture-in-picture-chrome-extension's People

Contributors

amine-h avatar beaufortfrancois avatar gotham13 avatar jpmedley avatar rspier avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

picture-in-picture-chrome-extension's Issues

Please upgrade chrome store plugin

Version: 69.0.3497.81(Official Build) (64 bits)

When Installing this extension from chrome store, it doesn't works well, but installing from source code it works well. It seems store's extension is not latest version. please upgrade.

Pause button stucks in pip

Hi!

When using pip, the pause button remains stuck in the video and doesn't disappear until you resize the video. But when you move the cursor over it again, it appears again.

As a reference, that's happening on my notebook (HP Envy X360) but it's working fine on my desktop PC.

Thank you!

Floating window doesn't carry over when changing work spaces

Hey!
Thanks for this awesome extension :D
I've been using it for a few months now and just realized today that the floating window does not carry over when I change work spaces anymore.
I remember previously swapping work spaces would take the floating window with it.
I'm using a linux desktop.
Thanks!
David :)

Resize pip window with pinch-to-zoom trackpad gesture

It would be awesome to have the ability to resize the pip window by pinching the trackpad (like how you zoom in on photos on your phone).

I don't know how easy it would be to implement, but I think it would make the pip experience a lot easier for me :)

Thanks for your work!

edit:
After looking at the code it seems like I've opened this issue at the wrong place, I'm sorry!

Browser crash when PiP's source element is removed

When using this plugin with Meet, the plugin will crash the entire browser if a meet participant whose video has been moved to PiP leaves the meet.
The PiP element becomes a frozen, then blank, black frame; and attempting to close it causes the GPU, Renderer, and main host processes to spin on the CPU for several moments before ultimately taking the entire browser down.

I've not been able to replicate this intentionally to get a crash report yet, as this was discovered through course of work, where crash reporting was disabled.

Hide window on taskbar Windows

It would be great if you could hide the window from the taskbar in Windows, I doubt the truth that this is possible in Windows, but if possible that would be great))

Netflix subtitles

First of all, thanks for all the hard work.

Is it possible that subtitles could show up in the floating window? That would be much better for watching Netflix.

Cannot read property 'width' of undefined

The extension fails on the following website https://www.hotstar.com/ with the following error
VM1604 script.js:22 Uncaught (in promise) TypeError: Cannot read property 'width' of undefined at VM1604 script.js:22 at Array.sort (<anonymous>) at VM1604 script.js:19 at VM1604 script.js:40

I don't know if it happens with any other website. I am attaching a screenshot as the website may not be available in all countries

2020-02-01 (1)

Modifying

const v1Rect = v1.getClientRects()[0];

const v2Rect = v2.getClientRects()[0];

To
const v1Rect = v1.getClientRects()[0]||{width:0,height:0};
const v2Rect = v2.getClientRects()[0]||{width:0,height:0};

Fixes the issue

2020-02-01 (2)

Full-screen button

It would be nice to include a button to put the video on full screen, this to avoid having to close the window and return to chrome to do this

Plex stuck in pip mode

Sometimes Plex will get stuck thinking the video is still in pip mode when it's not and it displays the text your video is in pip mode but I can't see any video with the black screen and pip window won't show up unless I reload the webpage

PiP extension doesn't work on FreeBSD

Hi,

It seems that the extension does not work on FreeBSD. Chromium 72.0.3626.119 stops working and crashes with any YouTube video.

Would it be possible to support FreeBSD?

Thanks

Doesn't work with upnext videos

I could have sworn an earlier version worked with up next videos on Plex Netflix and YouTube.

Being able to continually stream tv shows or next video on YouTube without having to exit the extension and then re enable the extension Each time for a new episode would be great to be able to stay in pip and let videos continue to stream with up next videos

Navigation Buttons

This is not a issue, this is a suggest, you should add buttons tu go back and forward while playing, something like netflix, ten seconds. And a button to restart or reload.
Thanks a lot.

Seekbar Support

Thansk for this great extension. I hope this extension can have seekbar which enable users to change time in picture-in-picture mode too.

Always-on-top setting can get disabled

Windows Version 10.0.19041.172

Somehow by switching between windows, the PiP window lost its always-on-top bit (perhaps via AutoHotKey meddling). Closing and re-opening the window doesn't help.

The workaround is to restart Chrome.

alt-p swallowed by PiP extension

When using remotedesktop.google.com (in a window, on ChromeOS) Alt-P is captured by the extension, instead of being sent through to the remote host.

I asked someone on the Chrome Remote Desktop team, and they said:
It uses the _execute_browser_action feature of extensions, which swallows keypresses unilaterally (as can be seen by using Keyboard Event Viewer with the extension active). It could be rewritten to use a content script and handle the key only if there are relevant elements on the page, but I don't know if the owner would be interested in doing that (it would still affect CRD, but we could set the disablePictureInPicture attribute on our video tag to avoid it).

Having some solution for not capturing Alt-P would be nice.

Main chrome window missing from ⌘+Tab on OSX

I don't know if this only happened to me, but I sometimes can't use ⌘+Tab to get the main window of chrome. The only window that appear are Picture in Picture. I can, however, get back to the main window by using the mission control (four finger swipe up). I also use this Contexts app so maybe that's the cause. Just wondering if anyone else also has this problem.

Feature: Add control bar、playlist and keyboard shortcuts

I really enjoy this PIP mode and using it replace some original video player provided by some site.

The annoying thing is we can't control the progress in the PIP window and have no corresponding keyboard shortcut.

Another feature request is wishing there is a playlist feature we can play nest video without exiting PIP and then back to video site and then request a new PIP to play.

Layout Instance of Picture in PIcture

Can this extension, can be put behind a certain application not always on the front of the screen or application. Thanks if you applied changes for this one. Hopefully that this issue can be addressed and modify the system

Extension only shows blank box after updating to Chrome 78

After updating to Chrome 78 when I click on the extension button to pull a video out to PiP all I see is a blank box that I can't interact with or move. The source video stops showing but the audio keeps playing. The only way to back out at that point is to click the extension button again and the video begins showing on the original page again.

The problem started with Chrome 78.3904.70 and continues with 78.3904.87.

PIP window won't appear

I installed the extension on my Chrome browser, and when I click on it while watching a YouTube video, the PIP window won't appear. I tried uninstalling and reinstalling the extension, but it still won't work.
My Chrome version: Version 83.0.4103.106 (Official Build) (64-bit)

Add option to disable analytics / tracking

Just looking at the source and noticed that google analytics data is being from within background.js. There should be a way to opt out of this in the settings in my opinion.

resizing error in the screen with changed resolution

When I use my screen with a %125 resolution, resizing not working properly. The video area slides to the right of the page after reaching the maximum size.

But it only happens when I use the left or one of the left corners to resize the video area. If I use the right sides it works properly.

picture-in-picture-issue-1

Remember Window Position and Size

Hi team,

I don't know if this would be possible considering this is a new API. But it would be nice to configure the position where the PIP window will open (or remember the past position). Similar to how js allows control over the size and position of popup windows.

Thanks for the hard work.

Small UI Requests

So far, this is a great extension! After using for a little bit, here are a couple things I think would greatly improve it:

  1. Button to jump back to the browser window.
  2. Global keyboard shortcut to show/hide the PIP window.
  3. Play head control — being able to scrub through a YouTube video would be great.

I'm a UX designer. I don't have the dev skills to make this happen, but would be happy to help with the visuals.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.