googlearchive / android-ui-toolkit-demos

Migrated:

This repo has been migrated to github.com/android/views-widgets. Please check that repo for future updates. Thank you!

android-ui-toolkit-demos's Issues

Request to change filter icon on YouTube Android

I noticed the filter icon in the YouTube app is a settings icon. Is there some open source org I can raise this feedback too change this? Is there some way I can contribute and help replace the icon?

what the current filter icon looks like > http://imgur.com/a/vKzkP

Error at hide view with text

Hello,

I'm using TransitionManager to animate some views at change visibility but I found a bug.

On my layout I have two buttons with constraint layout chain:

        <Button
                android:text="@string/email_button"
                android:paddingStart="16dp"
                style="@style/seasonTextColor"
                android:background="@drawable/round_button_background_center_info"
                android:textAllCaps="false"
                android:layout_width="0dp"
                android:layout_height="44dp"
                android:id="@+id/emailButton"
                android:layout_marginTop="16dp"
                app:layout_goneMarginTop="16dp"
                app:layout_constraintTop_toBottomOf="@+id/educatorsList"
                app:layout_constraintStart_toStartOf="parent"
                app:layout_constraintHorizontal_chainStyle="spread_inside"
                android:layout_marginStart="24dp"
                app:layout_constraintHorizontal_bias="0.5"
                app:layout_constraintEnd_toStartOf="@+id/callButton"/>

        <Button
                android:text="@string/call_button"
                android:background="@drawable/round_button_background_center_info_gradient"
                android:paddingStart="16dp"
                android:textColor="@color/white"
                android:layout_gravity="center"
                android:textAllCaps="false"
                android:layout_width="0dp"
                android:layout_height="44dp"
                android:id="@+id/callButton"
                app:layout_constraintTop_toTopOf="@+id/emailButton"
                app:layout_constraintEnd_toEndOf="parent"
                android:layout_marginEnd="24dp"
                app:layout_constraintStart_toEndOf="@+id/emailButton"
                app:layout_constraintHorizontal_bias="0.5"
                android:layout_marginStart="16dp"/>

Both are inside a group to manage visibility and when I use TransitionManager to show them It works but when I use it to hide them the text inside button reduce width until only one char is visible.

My code to change visibility is:

override fun hideCenterInfo() {
    TransitionManager.beginDelayedTransition(centerInfoContainer)
    centerInfoGroup?.visibility = View.GONE
}

Thank you!

DataBinding example with recyclerview cannot handle shared pool

The adapter in data binding examples add a callback when the ViewHolder is created but if the ViewHolder is shared between adapters, this won't work.
We should remove the listener when the ViewHolder is recycled and add it when bind is called for the first time.

confuse

what is the use of DataBindAdapter and DataBindViewHolder. It can do by normal RecylerViewAdapter.

Not using runPendingAnimations()?

Hi, thanks for the videos and this sample, it really helped me understand what is going on! Just a quick question on the implementation: you return true from animateChange(), but never make use of runPendingAnimations(), instead you just start the animations directly in animateChange(). But reading the docs, it seems like we are supposed to be determining if we need animations and creating the animations in the animateXXX() methods, then returning true if so, then starting them in runPendingAnimations(). Am I missing something? If we can simply start the animations directly in the animateXXX() methods, what is the purpose of runPendingAnimations()? Thanks again!

Register clicks on data in DataBoundList

I have implemented DataBoundList and so far working just fine.

Only problem is that it is not clear to me how to register clicks on individual data items.

Am new to the whole data binding in Android in general, so might have missed an obvious solution.

Thank you in advance