googleapis / proto3-json-serializer-nodejs Goto Github PK

The following release PRs may have failed:

• #39

GHSA-h755-8qp9-cq85

PR: #94

I'm aware of the name of the repo 😄 , but it would be nice to have direct support for the browser
without a polyfill for Buffer.

Looking at the code it seems that Buffer is only used for base64 encoding/decoding
of binary arrays, something that browser-friendly libraries like https://www.npmjs.com/package/base64-js do well.

Are there any plans? Is this something that you would be open to?

Proto3 float, double maps JSON number, need to support NaN, Infinity and -Infinity.

JSON value will be a number or one of the special string values "NaN", "Infinity", and "-Infinity". Either numbers or strings are accepted. Exponent notation is also accepted. -0 is considered equivalent to 0.

several places where the extra checks need to be added:
1 in fromProto3Json conversion, if a type is double and a value is one of the special values like "NaN", put the corresponding Number value instead of the string as is
2 in 'toProto3Json` conversion, do the same (but the other way around)
3 in google.protobuf.Value toJson conversion, do the same

The following release PRs may have failed:

• #39

The following release PRs may have failed:

• #47

This issue provides visibility into Renovate updates and their statuses. Learn more

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• chore(deps): update actions/setup-node action to v2

• Check this box to trigger a request for Renovate to run again on this repository

The following release PRs may have failed:

• #39

There is a CVE-2022-25878 security issue on protobufjs 6.11.2 which already fixed in protobufjs 6.11.3

So it's needed to update the npm package

I am happy to help to make PR for this change

Since this package's typings depend on protobufjs, which is explicitly imported, you must declare protobufjs as a dependency.

Please check: https://yarnpkg.com/getting-started/migration#fix-dependencies-with-packageextensions

This test failed!

To configure my behavior, see the Flaky Bot documentation.

If I'm commenting on this issue too often, add the flakybot: quiet label and
I will stop commenting.

commit: 6e20f58
buildURL: Build Status, Sponge
status: failed

Process 128 exited with code 1.
Error: Process 128 exited with code 1.
    at ChildProcess. (node_modules/pack-n-play/build/src/utils.js:48:22)
        -> /workspace/node_modules/pack-n-play/src/utils.ts:62:11
    at maybeClose (internal/child_process.js:1022:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:287:5)

Is your feature request related to a problem? Please describe.

Currently this serializer takes a reflected message Type as input for type in fromProto3JSON(type, json). However, I want to be able to use generated static code as described in https://github.com/protobufjs/protobuf.js#using-generated-static-code.

Describe the solution you'd like

Provide a feature or instruction for how to take the jspb.Message as input for deserialization: fromProto3JSON().

Describe alternatives you've considered

I found this PR relevant: https://github.com/googleapis/nodejs-ai-platform/pull/22/files