Do not show Enhanced Measurement banner when KMW setup CTA is visible about site-kit-wp

[aaemnnosttv]

@techanvil @hussain-t I've opened a PR for a simpler alternative approach that minimizes changes to existing components as we're on a bit of a time crunch for this release.

[techanvil]

Hi @hussain-t, thanks for drafting this IB. There are a few points to address:

If the KEY_METRICS_SETUP_CTA_WIDGET_SLUG item is dismissed (with the false value) AND

It's correct that we should check for isDismissed === false, but the wording of the point is wrong because this indicates the item has not been dismissed, this had me confused for a bit until I worked through it. So, please update the point along these lines:

If the KEY_METRICS_SETUP_CTA_WIDGET_SLUG item is not dismissed (specifically check for the false value) AND

I also found the following point a bit confusing, because it can suggest that the IB is only covering the dismissal of the banner:

This will prevent the banner from being rendered in response to dismissing the KM CTA (on the same page load).

I'd suggest updating this along these lines:

This will prevent the banner from being rendered when the KM CTA is present, and it will stay hidden when the KM CTA is dismissed (on the same page load).

Lastly, regarding the test coverage, KeyMetricsSetupCTAWidget also has some existing coverage so we could add a test there as well. This being the case, we might want to bump the estimate up too.

[hussain-t]

Thanks for your kind review, @techanvil. I have updated the iB.

[techanvil]

Thanks @hussain-t! The IB LGTM. ✅

[mohitwp]

QA Update ✅

• Tested on main environment.
• Verified that With a GA4 property that does not have EM enabled, the EM CTA is not displaying on the dashboard at the same time as the KM set up CTA.
• Verified that the banner not appear in response to dismissing the KM CTA (on the same page load)

Recording.660.mp4