Comments (5)
@techanvil @hussain-t I've opened a PR for a simpler alternative approach that minimizes changes to existing components as we're on a bit of a time crunch for this release.
from site-kit-wp.
Hi @hussain-t, thanks for drafting this IB. There are a few points to address:
If the
KEY_METRICS_SETUP_CTA_WIDGET_SLUG
item is dismissed (with thefalse
value) AND
It's correct that we should check for isDismissed === false
, but the wording of the point is wrong because this indicates the item has not been dismissed, this had me confused for a bit until I worked through it. So, please update the point along these lines:
If the
KEY_METRICS_SETUP_CTA_WIDGET_SLUG
item is not dismissed (specifically check for thefalse
value) AND
I also found the following point a bit confusing, because it can suggest that the IB is only covering the dismissal of the banner:
This will prevent the banner from being rendered in response to dismissing the KM CTA (on the same page load).
I'd suggest updating this along these lines:
This will prevent the banner from being rendered when the KM CTA is present, and it will stay hidden when the KM CTA is dismissed (on the same page load).
Lastly, regarding the test coverage, KeyMetricsSetupCTAWidget
also has some existing coverage so we could add a test there as well. This being the case, we might want to bump the estimate up too.
from site-kit-wp.
Thanks for your kind review, @techanvil. I have updated the iB.
from site-kit-wp.
Thanks @hussain-t! The IB LGTM. ✅
from site-kit-wp.
QA Update ✅
- Tested on main environment.
- Verified that With a GA4 property that does not have EM enabled, the EM CTA is not displaying on the dashboard at the same time as the KM set up CTA.
- Verified that the banner not appear in response to dismissing the KM CTA (on the same page load)
Recording.660.mp4
from site-kit-wp.
Related Issues (20)
- Release 1.129.0 HOT 7
- Use git lfs for reference images
- Console error: Cannot read properties of undefined (reading 'hasClass')
- Scroll to the Audiences Widget Area from the Setup Success Notice HOT 2
- Scroll to the Audience Segmentation Settings section when navigating there from links on the dashboard HOT 1
- Only render the Audience Segmentation Setup CTA when Analytics is connected HOT 2
- Clear the "temporarily hidden" state for an audience when it's removed from the audience selection HOT 6
- Revise Audience Segmentation component names/locations for consistency HOT 2
- Use the `useInViewSelect()` hook where applicable in the Audience Segmentation feature HOT 6
- Syncing audiences and custom dimensions in parallel can result in the cached audiences not being persisted HOT 1
- Add Tracking To The Conversion Tracking Toggle HOT 4
- Update the design of the Key Metrics setup CTA banner. HOT 4
- Use the correct title font for the Consent Mode Setup CTA Banner HOT 2
- Release 1.130.0 HOT 10
- E2E failing on WP Nightly (6.6) HOT 2
- Ads setup CTA appears immediately after connecting SK HOT 2
- Upgrade remaining GitHub Actions to Node 20 HOT 2
- `validateHaveSettingsChanged` Should Be Updated To Align With Existing Semantic Convention HOT 10
- Rename the `Migration_Conversion_ID` migration to `Migration_1_129_0` for consistency
- Prevent Selection Panel Info Notice from disappearing until two audiences are selected HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from site-kit-wp.