Comments (6)
Thanks @nfmohit - I should have been more explicit in the AC. The not should indeed not reappear - I've updated the AC accordingly.
from site-kit-wp.
Thank you for the confirmation and amendment, @techanvil !
@benbowler Thank you for the IB. Let's update it to make sure the notice doesn't reappear when the user reduces their selection to one audience. We may be able to use a local state in conjunction with a useEffect
to achieve this behaviour.
Also, could you also instruct to remove the AUDIENCE_SELECTED
form key if it is no longer needed? It was only added for this component as far as I know.
from site-kit-wp.
@techanvil Just to quickly confirm, what happens if the user unselects one of the audiences after they've selected two? Should the notice reappear? If not, the IB will need to be updated to address that behaviour. I'll write my IBR feedback based on your response, thank you!
from site-kit-wp.
Thank you for the update, @benbowler . I think 3 as an estimate is quite steep here just in case an unexpected side-effect comes up. Do you think it might be worth increasing it by a notch just so we're safe?
from site-kit-wp.
Good point, updated @nfmohit
from site-kit-wp.
Thanks @benbowler ! IB LGTM 👍 ✅
from site-kit-wp.
Related Issues (20)
- Compatibility to Real Cookie Banner
- Settings Footer Should Be Refactored As It has High Complexity
- Include a check for Analytics being connected in the conditions for rendering `AudienceSegmentationSetupCTAWidget` in `DashboardMainApp`. HOT 1
- PAX notice banner CTA external link opens in the same tab.
- 2nd tile has no data HOT 1
- Handle error of user count retrieval for audiences in partial data state
- `ConnectAnalyticsCTAWidget` graphics is not loading in IOS browsers HOT 1
- Allow `googlesitekit-*` modules to be imported piecemeal instead of entirely, similar to `googlesitekit-data`
- Tiles layout on mobile and tablet is broken
- Enable groups success message design on mobile doesn't align with Figma
- Improve awareness of subdomain treatment by AdSense during setup
- Detect malformed REST responses and display a specific error/help page link
- Improve widget level Error Handler UI/UX for small widget areas
- "Learn More" Link for Enhanced Conversion Tracking Toggle is Missing When Displayed Within Analytics Module Settings HOT 1
- "Learn More" Link for Enhanced Conversion Tracking Toggle is Missing When Displayed Within Analytics Module Settings HOT 1
- Four events are being tracked when we submit WP Forms with the Popup Maker plugin active.
- Update the getReferenceDate selector not to return a date object HOT 2
- Investigate Moving GA4 Action From `useMount` To The Module Specific Effects Component
- Event provider JS doesn't load on production build HOT 6
- Duplicate entries appear for `googlesitekit-components` in `manifest.php` when rebuilding via `npm run watch`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from site-kit-wp.