Prevent Selection Panel Info Notice from disappearing until two audiences are selected about site-kit-wp

[techanvil]

Thanks @nfmohit - I should have been more explicit in the AC. The not should indeed not reappear - I've updated the AC accordingly.

[nfmohit]

Thank you for the confirmation and amendment, @techanvil !

@benbowler Thank you for the IB. Let's update it to make sure the notice doesn't reappear when the user reduces their selection to one audience. We may be able to use a local state in conjunction with a useEffect to achieve this behaviour.

Also, could you also instruct to remove the AUDIENCE_SELECTED form key if it is no longer needed? It was only added for this component as far as I know.

[nfmohit]

@techanvil Just to quickly confirm, what happens if the user unselects one of the audiences after they've selected two? Should the notice reappear? If not, the IB will need to be updated to address that behaviour. I'll write my IBR feedback based on your response, thank you!

[nfmohit]

Thank you for the update, @benbowler . I think 3 as an estimate is quite steep here just in case an unexpected side-effect comes up. Do you think it might be worth increasing it by a notch just so we're safe?

[benbowler]

Good point, updated @nfmohit

[nfmohit]

Thanks @benbowler ! IB LGTM 👍 ✅

[mohitwp]

QA Update ✅

• Tested on main environment.
• Verified The Selection Panel Info Notice s appear only when the Selection Panel is opened with a single saved audience in the selection (this is as per the initial implementation).
• The notice remain visible until at least two audiences are selected. It not reappear if the user reduces the selection to a single audience while the selection panel remains open.
• Verified Once two audiences are selected the notice gets disappear.
• Verified If one is deselected again - notice not appear immediately, but only on the next opening.

Recording.1274.mp4