google / megalista Goto Github PK

Should be row.items() instead of conversion.items()

@jsraucci

I am having problems uploading data to Google Ads, even though it was working fine until a month ago

We have identified 1 possible instance of outdated documentation:

• megalist_dataflow was renamed to megalista_dataflow but the change has not been reflected in the current version of the Update instructions wiki page

About

This is part of a research project that aims to automatically detect outdated documentation in GitHub repositories. We are evaluating the validity of our approach by identifying instances of outdated documentation in real-world projects.

We hope that this research will be a step towards keeping documentation up-to-date. If this has been helpful, consider updating the documentation to keep it in sync with the source code. If this has not been helpful, consider updating this issue with an explanation, so that we can improve our approach. Thanks!

According to the documentation, the expected schema for Google Ads Customer Match Device ID table is

But in the source code, the field is mobileId.

def get_row_keys(self) -> List[str]:
    return ['mobileId']

Hi Guys, I'm using megalista to upload some audiences from bigquery to google analytics data import.

Right now you're checking the column names in the data source in bigquery with the schema 'cd\d+', but it doesn't work when we upload the data into google analytics, since the data import only accept 'dimension\d+' schema.

So, my recommendation is to change in the script megalista_dataflow/data_sources/data_source.py, the line:

'GA_DATA_IMPORT': {
    'columns': [
        {'name': 'cd\\d+', 'required': True, 'data_type': 'string'},
        {'name': 'cd\\d+', 'required': True, 'data_type': 'string'},
        {'name': 'cd\\d+', 'required': False, 'data_type': 'string'},
    ],
    'groups': []
},

for:

'GA_DATA_IMPORT': {
    'columns': [
        {'name': 'dimension\\d+', 'required': True, 'data_type': 'string'},
        {'name': 'dimension\\d+', 'required': True, 'data_type': 'string'},
        {'name': 'dimension\\d+', 'required': False, 'data_type': 'string'},
    ],
    'groups': []
},

Best,

Gibran

Hi There,

We are running Megalista implementation for a client for quite a long time. It's been working wonderfully so far.
However, in one of the scenarios, where we use the CM offline conversion upload functionality, it uploads all the data except Custom Variables. Below are the steps that we have performed and confirmed at our end.

1. All these custom variables are available and enabled on the floodlight level.
2. We also used regular API calls to push these same variables into the CM platform and that worked fine. So the problem is not with the data or setup on the CM part.

We value your time and effort. However, it would be of huge help if it would be possible to look at this from Megalista's end.
Any help or guidance would be highly appreciated, as we are not sure how to proceed beyond this point.

Additionally, if any input is needed from our end, we would be happy to contribute.

Thanks & Regards,
Sandhya

I have a doubt, @astivi and @caiotomazelli

The name of the repository and documentation is Megalista
But the folder structure uses the name megalist and some parameters as well.

We understand that the name of the solution is Megalista, and all coding must use the megalist nomenclature. Is correct?

I noticed that the README states:

Calls to the Google Ads API will fail if the user that generated the OAuth2 credentials (Access Token and Refresh Token) doesn't have direct access to the Google Ads account to which the calls are being directed. It's not enough for the user to have access to a MCC above this account and being able to access the account through the interface, it's required that the user has permissions on the account itself.

However, the Google Ads API client library for Java supports auth via manager access by specifying login-customer-id as described in https://developers.google.com/google-ads/api/docs/client-libs/java/config-file and https://developers.google.com/google-ads/api/docs/concepts/call-structure#cid.

Manually executing pipeline using Dataflow UI does not work with the provided template file throwing the following error:

Docker image not specified in the template file.

The deployment fails on a project where a subnetwork is defined. Please could you add a subnetwork key in the cloud configuration json and append its value on the dataflow call.
Most of our clients have subnets and need this feature. Thanks

Initializing the backend...

Initializing provider plugins...

• Finding latest version of hashicorp/google...
• Finding hashicorp/null versions matching "3.1.1"...
• Installing hashicorp/google v4.29.0...
• Installing hashicorp/null v3.1.1...
  ╷
  │ Error: Failed to install provider
  │
  │ Error while installing hashicorp/google v4.29.0: unexpected EOF
  ╵

╷
│ Error: Failed to install provider
│
│ Error while installing hashicorp/null v3.1.1: unexpected EOF
╵

I'm trying to send audience lists to Google Ads, but having the following error in all forms of Customer Match:

ERROR:megalista.GoogleAdsCustomerMatchAbstractUploader:'int' object has no attribute 'name' Traceback (most recent call last): File "/home/bianca_santos/google-marketing-data-sync/megalista-v2/megalista/megalista_dataflow/uploaders/utils.py", line 72, in inner return func(*args, **kwargs) File "/home/bianca_santos/google-marketing-data-sync/megalista-v2/megalista/megalista_dataflow/uploaders/google_ads/customer_match/abstract_uploader.py", line 209, in process execution.destination.destination_metadata)) File "/home/bianca_santos/google-marketing-data-sync/megalista-v2/megalista/megalista_dataflow/uploaders/google_ads/customer_match/abstract_uploader.py", line 60, in _create_list_if_it_does_not_exist customer_id, list_name, list_definition) File "/home/bianca_santos/google-marketing-data-sync/megalista-v2/megalista/megalista_dataflow/uploaders/google_ads/customer_match/abstract_uploader.py", line 70, in _do_create_list_if_it_does_not_exist resource_name = self._get_user_list_resource_name(customer_id, list_name) File "/home/bianca_santos/google-marketing-data-sync/megalista-v2/megalista/megalista_dataflow/uploaders/google_ads/customer_match/abstract_uploader.py", line 109, in _get_user_list_resource_name query_aux = f"AND user_list.access_reason={ads_client.enums.AccessReasonEnum.OWNED.name}" AttributeError: 'int' object has no attribute 'name' ERROR:megalista.GoogleAdsCustomerMatchAbstractUploader:Error uploading data. Traceback (most recent call last): File "/home/bianca_santos/google-marketing-data-sync/megalista-v2/megalista/megalista_dataflow/uploaders/utils.py", line 72, in inner return func(*args, **kwargs) File "/home/bianca_santos/google-marketing-data-sync/megalista-v2/megalista/megalista_dataflow/uploaders/google_ads/customer_match/abstract_uploader.py", line 209, in process execution.destination.destination_metadata)) File "/home/bianca_santos/google-marketing-data-sync/megalista-v2/megalista/megalista_dataflow/uploaders/google_ads/customer_match/abstract_uploader.py", line 60, in _create_list_if_it_does_not_exist customer_id, list_name, list_definition) File "/home/bianca_santos/google-marketing-data-sync/megalista-v2/megalista/megalista_dataflow/uploaders/google_ads/customer_match/abstract_uploader.py", line 70, in _do_create_list_if_it_does_not_exist resource_name = self._get_user_list_resource_name(customer_id, list_name) File "/home/bianca_santos/google-marketing-data-sync/megalista-v2/megalista/megalista_dataflow/uploaders/google_ads/customer_match/abstract_uploader.py", line 109, in _get_user_list_resource_name query_aux = f"AND user_list.access_reason={ads_client.enums.AccessReasonEnum.OWNED.name}" AttributeError: 'int' object has no attribute 'name' INFO:megalista.GoogleAdsOfflineUploader:Uploading 1000 rows... INFO:megalista.GoogleAdsOfflineConversionsUploader:Uploading 1000 offline conversions on customers/5852184472/conversionActions/792598949 to Google Ads. ERROR:megalista.GoogleAdsOfflineConversionsUploader:Error on uploading offline conversions: Multiple errors in ‘details’. First error: The click or call is owned by a customer account that the uploading customer does not manage., at conversions[0].gclid. INFO:megalista:Completed successfully!

The account is a MCC Google Ads Account.

Hi there,

I am not able to enable Google Ads(ADS_CUSTOMER_MATCH_MOBILE_DEVICE_ID_UPLOAD) and keep getting following issue.

[Action Required] Megalista error detected - ADS_CUSTOMER_MATCH_MOBILE_DEVICE_ID_UPLOAD
......
......
......
"file":"src/core/lib/surface/call.cc","file_line":1074,"grpc_message":"Request contains an invalid argument.","grpc_status":3}" >, errors { error_code { request_error: DEVELOPER_TOKEN_PARAMETER_MISSING } message: "developer-token parameter is missing." } request_id: "ciDlQz5F_Uv9FWBewaSZuw" , 'ciDlQz5F_Uv9FWBewaSZuw')

Thanks,
-Askar