google / cwv_in_ga4 Goto Github PK

To help manage the number of events sent to GA4, it would be good to be able to select a sub-set of the core web vitals to collect.

Script might be manipulating with Google Cloud APIs, crete scheduled queries etc, which is not be clear to the user. Should add more logs which can also help with future debugging

The data transfer API needs to be enabled before using the solution. Preferably, this should be done as part of the deployment script. Otherwise it needs to be called out explicitly in the docs.

The script enables some services that aren't available immediately. The script should implement a delay and retry the action if it fails due to a service not yet being available.

It's not clear how much deploying the solution might cost. It would be good to have an overall cost overview, with a breakdown for the different services.

Not all of the service required for deployment are enabled automatically via the script. For example, eventarc seems to be missing.

All of the services required for the deployment to work should be enabled by the script automatically.

The solution will fail if the computer engine api isn't enabled. Preferably, this should be done automatically as part of the deploy script. Otherwise it needs to be explicitly called out in the docs.

It would be good to be able to choose whether to use the attribution build of the web-vitals if needed.

Using one of the umbrella regions (e.g. EU) for the project causes the deployment to fail. One of the specific regions (e.g. europe-west1) needs to be chosen.

This should be documented and, even better, a check should be added to the deployment.

The anchor marks (e.g. {#mark} in the README are being rendered as text instead of as anchors in the README. They should be updated to match GitHub's markdown implementation.

Running the deploy script results in the following error:

details = "Failed to find a valid credential. The request to create a transfer config is supposed to contain an authorization code."

The trace looked like this:

 File "/home/adamread/cwv_in_ga4/./deploy.py", line 579, in <module>
    main()
  File "/home/adamread/cwv_in_ga4/./deploy.py", line 518, in main
    deploy_scheduled_materialize_query(project_id, args.region, args.ga_property)
  File "/home/adamread/cwv_in_ga4/./deploy.py", line 236, in deploy_scheduled_materialize_query
    transfer_config = transfer_client.create_transfer_config(
  File "/home/adamread/.local/lib/python3.9/site-packages/google/cloud/bigquery_datatransfer_v1/services/data_transfer_service/client.py", line 757, in create_transfer_config
    response = rpc(request, retry=retry, timeout=timeout, metadata=metadata,)
  File "/home/adamread/.local/lib/python3.9/site-packages/google/api_core/gapic_v1/method.py", line 154, in __call__
    return wrapped_func(*args, **kwargs)
  File "/home/adamread/.local/lib/python3.9/site-packages/google/api_core/grpc_helpers.py", line 68, in error_remapped_callable
    raise exceptions.from_grpc_error(exc) from exc
google.api_core.exceptions.InvalidArgument: 400 Failed to find a valid credential. The request to create a transfer config is supposed to contain an authorization code.