gooddata / gooddata-java Goto Github PK

View Code? Open in Web Editor NEW

19.0 19.0 62.0 4.5 MB

GoodData Java SDK

License: Other

Java 87.65% Groovy 12.35%

gooddata-java's People

Contributors

Stargazers

Watchers

Forkers

aerondir liry17 jumarko peter-plochan caohhung liry michalvanco vhtien sadam21 jakub-plichta jdenk dkatona ostumpf benky ldkhoa jansyk13 zdenekkostal to-da petrvales anhnguyenthiquynh tu-ngo standevgd hung-nguyen-hoang mrataj-gd jorgeleyvar mmensik tuan-tran-thanh mmatula bredy xorel martinmosko mverbovsky peterlacko thuanlhv xmort lukas-slovak dominick1993 vlastikcz yanlipnican sitina milankovacik apascenko pmsgd sdelaney christian7877 janchochol phong-nguyen-duy vietnguyen1989 anvuong119 koles vu-pham daniel-rusnak jeskepetr viniciusnicolaus helobinvn cipous jaroslavramba thaoctthanh jklucka tomaso tqtu coffeeandchill229

gooddata-java's Issues

Use new Warehouse URI: /gdc/datawarehouse

closed by #65

Fix ModelService

make method ModelService.getProjectModelDiff(Project, DiffRequest) protected (it is not usable for user)
remove method ModelService.updateProjectModel(Project, ModelDiff) which is wrong - it runs all the MAQLs returned by the diff API (eg. destructive and non-destructive)
add method to ModelDiff class should to pick the best UpdateScript
add method ModelService.updateProjectModel(Project, UpdateScript)
add method ModelService.updateProjectModel(Project, Reader)
method ModelService.updateProjectModel() should read error (instead of throw new ModelException("Update project model finished with status ERROR");

Use Coveralls to measure test coverage

https://github.com/trautonen/coveralls-maven-plugin
http://blog.eluder.org/2013/06/code-coverage-for-github-hosted-java-projects-with-coveralls

Make the SDK easily extensible

Let experienced user to plugin own developed service configured/initialized with the same restTemplate as built-in services.

Set HTTP user agent

identify java sdk with version
identify gooddata http client version

Improve error logging (at least requestId)

If any execution fails, the error output is not very friendly, e.g.

org.springframework.web.client.RestTemplate handleResponseError
WARNING: POST request for "/gdc/md/XXX/obj" resulted in 400 (Bad Request); invoking error handler

I would prefer to get a requestId or any other error identification.

add support for relative upload paths in DataStoreService

closed by #23

GoodData client doesn't work with Jackson2 on classpath

Exception in thread "main" org.springframework.http.converter.HttpMessageNotReadableException: Could not read JSON: No suitable constructor found for type [simple type, class com.gooddata.project.Project]: can not instantiate from JSON object (need to add/enable type information?)
 at [Source: org.apache.http.client.entity.LazyDecompressingInputStream@25da8379; line: 1, column: 2]; nested exception is com.fasterxml.jackson.databind.JsonMappingException: No suitable constructor found for type [simple type, class com.gooddata.project.Project]: can not instantiate from JSON object (need to add/enable type information?)
 at [Source: org.apache.http.client.entity.LazyDecompressingInputStream@25da8379; line: 1, column: 2]
    at org.springframework.http.converter.json.MappingJackson2HttpMessageConverter.readJavaType(MappingJackson2HttpMessageConverter.java:181)
    at org.springframework.http.converter.json.MappingJackson2HttpMessageConverter.read(MappingJackson2HttpMessageConverter.java:173)
    at org.springframework.web.client.HttpMessageConverterExtractor.extractData(HttpMessageConverterExtractor.java:94)
    at org.springframework.web.client.RestTemplate.doExecute(RestTemplate.java:496)
    at org.springframework.web.client.RestTemplate.execute(RestTemplate.java:452)
    at org.springframework.web.client.RestTemplate.getForObject(RestTemplate.java:222)
    at com.gooddata.project.ProjectService.getProjectByUri(ProjectService.java:114)
    at com.gooddata.project.ProjectService.getProjectById(ProjectService.java:135)

The problem is in RestTemplate constructor which favours Jackson2 over Jackson1:

if (jackson2Present) {
    this.messageConverters.add(new MappingJackson2HttpMessageConverter());
}
else if (jacksonPresent) {
    this.messageConverters.add(new MappingJacksonHttpMessageConverter());
}

Ease dataset manifest operations

set upload mode for all parts
set mapping - map CSV column name to the dataset field

GoodData object initialized with http protocol returns error 302

GoodData object initialized with http protocol instead of default https

goodData = new GoodData(hostname, username, password, 80, "http")
project = goodData.getProjectService().getProjectById(projectId)

returns error when accessing project using ProjectService

com.gooddata.http.client.GoodDataAuthException: Unable to login: 302
    at com.gooddata.http.client.LoginSSTRetrievalStrategy.obtainSst(LoginSSTRetrievalStrategy.java:77)
    at com.gooddata.http.client.GoodDataHttpClient.handleResponse(GoodDataHttpClient.java:168)
    at com.gooddata.http.client.GoodDataHttpClient.execute(GoodDataHttpClient.java:290)
    at com.gooddata.http.client.GoodDataHttpClient.execute(GoodDataHttpClient.java:255)
    at org.springframework.http.client.HttpComponentsClientHttpRequest.executeInternal(HttpComponentsClientHttpRequest.java:88)
    at org.springframework.http.client.AbstractBufferingClientHttpRequest.executeInternal(AbstractBufferingClientHttpRequest.java:46)
    at org.springframework.http.client.AbstractClientHttpRequest.execute(AbstractClientHttpRequest.java:49)
    at org.springframework.http.client.InterceptingClientHttpRequest$RequestExecution.execute(InterceptingClientHttpRequest.java:91)
    at com.gooddata.HeaderSettingRequestInterceptor.intercept(HeaderSettingRequestInterceptor.java:32)
    at org.springframework.http.client.InterceptingClientHttpRequest$RequestExecution.execute(InterceptingClientHttpRequest.java:81)
    at org.springframework.http.client.InterceptingClientHttpRequest.executeInternal(InterceptingClientHttpRequest.java:67)
    at org.springframework.http.client.AbstractBufferingClientHttpRequest.executeInternal(AbstractBufferingClientHttpRequest.java:46)
    at org.springframework.http.client.AbstractClientHttpRequest.execute(AbstractClientHttpRequest.java:49)
    at org.springframework.web.client.RestTemplate.doExecute(RestTemplate.java:488)
    at org.springframework.web.client.RestTemplate.execute(RestTemplate.java:452)
    at org.springframework.web.client.RestTemplate.getForObject(RestTemplate.java:222)
    at com.gooddata.project.ProjectService.getProjectByUri(ProjectService.java:114)
    at com.gooddata.project.ProjectService.getProjectById(ProjectService.java:135)

DataStoreService doesn't work with relative upload/download paths

service.upload("foo", stream);

tries to upload to /uploadsfoo

enable look for process executionDetail during execution is running

Add ability to export report

Util now we can export report definition only.

add execution detail links getters

closed by #56

Report export returns polling uri instead of expected data

When exporting larger reports, exportReport() method writes polling uri to the output stream instead of expected data. It looks like a problem with missing polling strategy, because it occurs only sometimes, usually with larger reports.

Deploy dataload process larger than 1MB

now only multipart post is supported

Use createAndGet when creating metadata object

POST /gdc/md/project/obj?createAndGet=true

if set to true returns full representation of the object after creation

enable other than login+password authentication

depends on gooddata/gooddata-http-client#16
authentication for WebDAV (via Sardine) #213
add possibility to create GoodData from SST instead of login and password
related internal issue: MSF-10020

Introduce GridElement inheritance

GridElement can be one of

metricGroup (a string, can be maximally one time in rows or columns)
URI (URI is allowed for backward compatibility)
current GridElement (originally called AttributeInGrid)

We probably should introduce some type hierarchy over GridElement.

Also type of Grid.columns should be Collection<GridElement> not Collection<String>

project is not created within 5 poll requests

(it was created in about one minute)

Review Meta/Content/Links in DTOs

Reduce dependencies

replace commons-io with spring
remove unnecesary spring deps

rename getSelfLink to getUri

closed by #53

add optimize SLI hash method

Add support for async etl/pull2 resource

Rename Process/Processes to DataloadProcess/DataloadProcesses

Introduced in #55 and #63 but the change is not backward compatible.

search for a single metadata item based on various restrictions

closed by #33

Process upload_status.json after dataset load failure

Data Warehouse support

closed by #48

implement batch upload API

Update hamcrest dependency in pom

In com.gooddata.md.AttributeTest you use org.hamcrest.Matchers.hasSize function
which is unavailable in 1.3 release in hamcrest

GoodDataAuthException is thrown on invalid login/pass

com.gooddata.http.client.GoodDataAuthException: Unable to login: 403
    at com.gooddata.http.client.LoginSSTRetrievalStrategy.obtainSst(LoginSSTRetrievalStrategy.java:77)
    at com.gooddata.http.client.GoodDataHttpClient.handleResponse(GoodDataHttpClient.java:168)
    at com.gooddata.http.client.GoodDataHttpClient.execute(GoodDataHttpClient.java:290)
    at com.gooddata.http.client.GoodDataHttpClient.execute(GoodDataHttpClient.java:255)
    at org.springframework.http.client.HttpComponentsClientHttpRequest.executeInternal(HttpComponentsClientHttpRequest.java:88)
    at org.springframework.http.client.AbstractBufferingClientHttpRequest.executeInternal(AbstractBufferingClientHttpRequest.java:46)
    at org.springframework.http.client.AbstractClientHttpRequest.execute(AbstractClientHttpRequest.java:49)
    at org.springframework.http.client.InterceptingClientHttpRequest$RequestExecution.execute(InterceptingClientHttpRequest.java:91)
    at com.gooddata.HeaderSettingRequestInterceptor.intercept(HeaderSettingRequestInterceptor.java:32)
    at org.springframework.http.client.InterceptingClientHttpRequest$RequestExecution.execute(InterceptingClientHttpRequest.java:81)
    at org.springframework.http.client.InterceptingClientHttpRequest.executeInternal(InterceptingClientHttpRequest.java:67)
    at org.springframework.http.client.AbstractBufferingClientHttpRequest.executeInternal(AbstractBufferingClientHttpRequest.java:46)
    at org.springframework.http.client.AbstractClientHttpRequest.execute(AbstractClientHttpRequest.java:49)
    at org.springframework.web.client.RestTemplate.doExecute(RestTemplate.java:488)
    at org.springframework.web.client.RestTemplate.execute(RestTemplate.java:452)
    at org.springframework.web.client.RestTemplate.getForObject(RestTemplate.java:222)
    at com.gooddata.account.AccountService.getCurrent(AccountService.java:33)

but com.gooddata.GoodDataException should be thrown.

Unit tests failing on Windows OS

Please see below the invalid handling of paths (when running unit tests on Windows)

-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running TestSuite
Configuring TestNG with: org.apache.maven.surefire.testng.conf.TestNG652Configurator@53a9d5
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
Tests run: 154, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 1.28 sec <<< FAILURE!
testMergeUrisWithSlash(com.gooddata.UriPrefixerTest) Time elapsed: 0 sec <<< FAILURE!
java.lang.AssertionError:
Expected: is "http://localhost:1/uploads/test"
but: was "http://localhost:1/😦%5Cuploads%5Ctest"
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:8)
at com.gooddata.UriPrefixerTest.testMergeUrisWithSlash(UriPrefixerTest.java:19)

testMergeUrisWithoutSlash(com.gooddata.UriPrefixerTest) Time elapsed: 0 sec <<< FAILURE!
java.lang.AssertionError:
Expected: is "http://localhost:1/uploads/test"
but: was "http://localhost:1/😦%5Cuploads%5Ctest"
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:8)
at com.gooddata.UriPrefixerTest.testMergeUrisWithoutSlash(UriPrefixerTest.java:26)

shouldZipDir(com.gooddata.util.ZipUtilsTest) Time elapsed: 0 sec <<< FAILURE!
java.lang.AssertionError:
Expected: is "toZip/a/b/someFile.txt"
but: was "toZip\a\b\someFile.txt"
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:8)
at com.gooddata.util.ZipUtilsTest.verifyZipContent(ZipUtilsTest.java:97)
at com.gooddata.util.ZipUtilsTest.shouldZipDir(ZipUtilsTest.java:56)

shouldZipDirWithoutRoot(com.gooddata.util.ZipUtilsTest) Time elapsed: 0 sec <<< FAILURE!
java.lang.AssertionError:
Expected: is "a/b/someFile.txt"
but: was "a\b\someFile.txt"

Update and retrieve connector integrations

Handle exceptions

Failed to load class "org.slf4j.impl.StaticLoggerBinder"

During GoodData initialization, it throws a logging warning:
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

Review data types in DTOs (Booleans, Dates etc.)

Dataload Processes support

closed by #48

enable stop process execution

Missing dependency on apache http client

Could lead to some NoClassDefFound etc., required version is 0.8.2+, it doesn't work properly with 0.8.1

ProcessService create and update process can't handle already zipped input

it tries to zip the input once more, which leads to exception. The SDK should either somehow detect zip input and not to zip it again, or we should add some parameter saying what's the input

AttributeInGrid incorrect serialization/deserialization

AttributeInGrid is not properly serialized/deserialized when part of ReportDefinition. Result JSON is missing "attribute" wrapper.

Actual

{
    "uri": "/gdc/md/FoodMartDemo/obj/8362",
    "totals": [],
    "alias": ""
}

Expected:

{
    "attribute": {
        "uri": "/gdc/md/FoodMartDemo/obj/8362",
        "totals": [],
        "alias": ""
    }
}

Improve project metric creation not to add obj/IDs

Right now, you have to add objects identifications to create metric, it would be helpful to add only string identifications or add ability to load object IDs before creating metric.

Example, instead of:
Metric metric = new Metric(
"Count XXX",
"SELECT COUNT([/gdc/md/XXX/obj/XXX]) WHERE " +
"[/gdc/md/XXX/obj/XXX] NOT IN " +
"([/gdc/md/XXX/obj/XXX/elements?id=XXX])", "#,##0");

Metric metric = new Metric(
"Count XXX",
"SELECT COUNT(XXX.YYY) WHERE " +
"XXX.YYY NOT IN " +
"XXX.YYY.ZZZ", "#,##0");
or
String obj = metadataService.getAttributeId("XXX.YYY");
and then
Metric metric = new Metric("Count XXX", "SELECT COUNT(%s)".format(obj), "#,##0");