golang-commonmark / markdown Goto Github PK

given

package main

import (
	"github.com/golang-commonmark/markdown"
)

func main() {
	markdown.New(markdown.Quotes("áéíó"))
}

you get

panic: runtime error: index out of range

goroutine 1 [running]:
panic(0x5b1d00, 0xc82000a140)
	/usr/lib/go-1.6/src/runtime/panic.go:481 +0x3e6
github.com/golang-commonmark/markdown.Quotes.func1(0xc820074a00)
	src/github.com/golang-commonmark/markdown/options.go:30 +0x92
github.com/golang-commonmark/markdown.New(0xc82012bf18, 0x1, 0x1, 0xc820116500)
	src/github.com/golang-commonmark/markdown/markdown.go:56 +0xeb
main.main()
	bruk.go:8 +0x87
exit status 2

• stop converting tabs into 4 spaces
• make sure space/whitespace spec clarification is just a clarification and current implementation isn't broken
• close open tags at the end of block quote and item list
• implement 7 types of html block
• limit ordered list markers to 9 digits
• make sure link fragments and query parameters work correctly
• add support for nested links and emphasis

Hi,

I try to test your project but it fails :
command: go test -buildmode pie -compiler gc -ldflags "-X gitlab.com/golang-commonmark/markdown/version.commit=246aecf104611b4ecb30fe0f1c2655bda38b7324 -X gitlab.com/golang-commonmark/markdown/version=0 -extldflags '-Wl,-z,relro '"
testing: gitlab.com/golang-commonmark/markdown
gitlab.com/golang-commonmark/markdown

gitlab.com/golang-commonmark/markdown [gitlab.com/golang-commonmark/markdown.test]

./markdown_benchmark_test.go:52:14: undefined: "github.com/russross/blackfriday".HtmlRenderer
./markdown_benchmark_test.go:52:39: undefined: "github.com/russross/blackfriday".HTML_USE_XHTML
./markdown_benchmark_test.go:52:66: undefined: "github.com/russross/blackfriday".HTML_USE_SMARTYPANTS
./markdown_benchmark_test.go:52:99: undefined: "github.com/russross/blackfriday".HTML_SMARTYPANTS_LATEX_DASHES
./markdown_benchmark_test.go:56:23: too many arguments to conversion to "github.com/russross/blackfriday".Markdown: "github.com/russross/blackfriday".Markdown(data, renderer, "github.com/russross/blackfriday".EXTENSION_NO_INTRA_EMPHASIS | "github.com/russross/blackfriday".EXTENSION_TABLES | "github.com/russross/blackfriday".EXTENSION_FENCED_CODE | "github.com/russross/blackfriday".EXTENSION_AUTOLINK | "github.com/russross/blackfriday".EXTENSION_STRIKETHROUGH)
FAIL gitlab.com/golang-commonmark/markdown [build failed]

I suppose you are using the old version of blackfriday (which is now in version 2) and old path
(gopkg.in/russross/blackfriday.v2)

• Export to GitLab (DONE: see gitlab.com/golang-commonmark)
• Update import paths
• Update README.md on GitHub
• Delete this repository 01-Oct-2018