goedemiddag / laravel-autodiscovery-lock Goto Github PK

Is your feature request related to a problem? Please describe.

We need Laravel 10 support

Describe the solution you'd like

Laraevl 10 support

Versions

• Laravel Version: 10.x

As of today, November 29th, php 7.4 is no longer supported. We should create a new major where we drop php 7.4 and make use of all the new features of PHP.
We can retain version 1.0 for projects yet to upgrade to PHP 8.x

Right now we have configured php-cs-fixer, but we don't actually check if it has been run on pr. Adding a check to the actions would ensure the code style stays up to date.

Describe the bug

Whenever composer is ran with dev packages included, the service providers and facades of these dev packages are included in the autodiscover.lock. This should not be the case, since this will always give a mismatch on locked items when ran in a build pipeline.

To Reproduce

Steps to reproduce the behavior:

1. require a package with --dev,
2. Run the script to generate the autodiscovery.lock

Expected behavior

packages installed with require-dev should be ommited. a notice should be displayed on screen when --require-dev is added to the composer install script notifying the user that autodiscovery.lock will ommit all packages in the require-dev area.

Right now MIT is specified in composer.json, to remove ambiguity a "proper" license file should be added

Collections right now are very generic, and only used for their formatting functions.
This should be done in a Value Object. This will have multiple advantages.

• readonly usage
• property promotion
• etc