gobblejs / gobble-rollup Goto Github PK

Rollup 0.12 has some nice new features, I would love to use them with gobble.

I updated the dependency of rollup to 0.26.1 to get rid of rollup/rollup#618.

@Rich-Harris Can you please git pull && npm publish this?

May be a rollup issue, but thought I'd start here.

Best I can tell the isExternal function doesn't work correctly and plugins never get called. I noticed options.external and tried some stuff out, but over my head figuring out how that iteracts with calling plugins.

Output looks like:

input:  /Users/marty/rollup-rxjs/.gobble-build/01-include/1
output: /Users/marty/rollup-rxjs/.gobble-build/02-rollup/1
>>>
Cannot find module 'rxjs/Observable' from '/Users/marty/rollup-rxjs/.gobble-build/01-include/1'
Error: Cannot find module 'rxjs/Observable' from '/Users/marty/rollup-rxjs/.gobble-build/01-include/1'

Here's branch with simple example project I'm hacking on to try this.

Imagine a gobble workflow which rolls up some files like these:

/home/ivan/projects/wonderfulweb/src/something.js
/home/ivan/projects/wonderfulweb/src/utils.js
...etc

Into this:

/home/ivan/projects/wonderfulweb/.gobble/31-merge/1/bundle.js
/home/ivan/projects/wonderfulweb/.gobble/31-merge/1/bundle.js.map

In cases like this, bundle.js.map is using relative sources, it looks like:

{"version":3,"sources":["../../../src/something.js","../../../src/utils.js", ...etc...

Any source path containing .. will make it useless in Firefox, and Error loading source: loadSourceError will be shown in the developer console (the only real symptom visible). Chrome works around ..s by silently dropping them. I haven't really tried any other browsers.

Ideally, filename paths in the rollup sourcemap should be relative to the location of the gobblefile.js, and not relative to the bundled file.