Comments (2)
hi i test that it happen just when i use refresh in shiori and if i use ctrl + F5 it fix.
somehow refresh can't clean cache of browser but i don't find why it happen for some of bookmark yet
@fmartingr do you have any idea?
update: i test that in firefox.
update:
change this part
shiori/internal/view/assets/js/component/bookmark.js
Lines 96 to 100 in 595cb45
to somthing like this solve problem in my tests
thumbnailStyleURL() {
const cacheBuster = new Date().getTime(); // Unique timestamp
const thumbnailWithCacheBuster = `${this.imageURL}?cache=${cacheBuster}`;
return {
backgroundImage: `url("${thumbnailWithCacheBuster}")`,
};
},
what do you think? any better solution?
if it is fine to you send i will send a PR to fix that.
@DesarrolloAntonio can you test this on your system and report if problem will solve with this change for you too?
from shiori.
hi i test that it happen just when i use refresh in shiori and if i use ctrl + F5 it fix. somehow refresh can't clean cache of browser but i don't find why it happen for some of bookmark yet @fmartingr do you have any idea?
update: i test that in firefox.
update: change this part
shiori/internal/view/assets/js/component/bookmark.js
Lines 96 to 100 in 595cb45
to somthing like this solve problem in my tests
thumbnailStyleURL() { const cacheBuster = new Date().getTime(); // Unique timestamp const thumbnailWithCacheBuster = `${this.imageURL}?cache=${cacheBuster}`; return { backgroundImage: `url("${thumbnailWithCacheBuster}")`, }; },
what do you think? any better solution? if it is fine to you send i will send a PR to fix that.
@DesarrolloAntonio can you test this on your system and report if problem will solve with this change for you too?
In the Android app PageKeeper, I fixed it with a similar solution, but instead of a timestamp, I added the "modified" field.
// Append 'lastUpdated' query to image URL for cache busting. Forces retrieval of updated images.
val imageUrl = "${serverURL.removeTrailingSlash()}${bookmark.imageURL}?lastUpdated=${bookmark.modified}"
from shiori.
Related Issues (20)
- Parsing error and missing content on theregister.com
- Container image tag "latest" is not updated v1.6.0 HOT 2
- Investigate mysql database url using password with special characters not working HOT 5
- Cannot rename tags in v1.6.0
- Some API calls do not respect root path HOT 6
- Improve search behavior
- Apache reverse proxy does not work for me HOT 24
- Shiori auto increasment not work currectly on sqlite database HOT 1
- Search API Fails to Return Results for Multi-Keyword Queries HOT 4
- Can't use anymore after last upgrade HOT 2
- Shiori can't migrate from 1.6.3 to last commit in master, if you use Postgres or Mariadb HOT 4
- Unify datetime manipulation for the multiple database engines
- Home button should clear search query
- PUT request to /api/v1/bookmarks/cache takes too long HOT 2
- Allow PDF file archives
- "View Original" link in the archive view references the same page HOT 1
- Frontend refactor to Vue3
- Some asset take so much time to load when became behind revece proxy HOT 2
- Update the usage docs
- Allow running arbitrary actions over bookmarks HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shiori.