Some API calls do not respect root path about shiori

[fmartingr]

Hi @fmartingr, yes and yes respectively. To be clear, if those aren't set the app doesn't load correctly- my app is loading and saving bookmarks no problem, but only certain API calls fail as per the title. If you double-check my description, I already linked to what I believe is the problem.

I just wanted to confirm the problem which seems to be the slash at the beginning of those calls ignoring the root path in the base element.

Also as a side note, it's incredibly confusing to have both the SHIORI_HTTP_ROOT_PATH env var and a --webroot argument.

Yeah, this is a bug, only one should be required, potentially to be fixed in 1.6.1 this week once I merge #865

[fmartingr]

Hey @ChaosExAnima, apologies for this. Let's figure out what's going on.

• Have you set the --webroot flag to /shiori? (Assuming yes, but wanted to confirm)
• Can you check if you have a <base href> and that the href attribute is correct with your webroot under Shiori's page source?

Note: Cann this be another side effect of #865?

[ChaosExAnima]

Hi @fmartingr, yes and yes respectively. To be clear, if those aren't set the app doesn't load correctly- my app is loading and saving bookmarks no problem, but only certain API calls fail as per the title. If you double-check my description, I already linked to what I believe is the problem.

Also as a side note, it's incredibly confusing to have both the SHIORI_HTTP_ROOT_PATH env var and a --webroot argument.

[fmartingr]

Can you check if this was solved with v1.6.1?

[ChaosExAnima]

@fmartingr - not fixed, no.

[fmartingr]

@fmartingr - not fixed, no.

Ups, sorry, I thought this was another ticket! Let me do a quick PR for this.