Coder Social home page Coder Social logo

youngcart5's Introduction

youngcart5's People

Contributors

chicpro avatar leebokyung avatar loves2tu avatar minsupkr avatar seeoya avatar sora90224 avatar thisgun avatar whitedot avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

youngcart5's Issues

uri.lib.php each() 함수

while(list($k,$v) = each($s)) $return_url .= '/'.$v;

each 함수가 Deprecated 되어서 오류가 발생하는데 이대로 가는건가요?

상품의 선택옵션(필수옵션)이 첫번째만 검사합니다.

우선 이런 좋은 오픈소스를 개발/유지해주셔서 감사합니다.

https://github.com/gnuboard/youngcart5/blob/master/shop/cartupdate.php#L132

if($opt_count && $_POST['io_type'][$it_id][0] != 0)
            alert('상품의 선택옵션을 선택해 주십시오.');

첫번째에 대해서만 검사를 하고 있습니다.
for문으로 모든 io_type 변수를 검사하는 것이 필요할 것 같습니다.
테마(스킨)에 따라 순서가 바뀌어올 수 있기 때문입니다.

개인적으로 수정해서 쓰고있는데 필요하시면 PR 드리겠습니다.

주문서 비밀번호 누락 위험성

/shop/orderformupdate.php:474

if ($is_member)
    $od_pwd = $member['mb_password'];
else
    $od_pwd = get_encrypt_string($_POST['od_pwd']);

server-side $od_pwd validation 필요합니다.
8자 이하일경우 sql_password() 로 암호화 불가능하여 공백 반환됩니다.

cart.php 수정사항

282줄, 297줄에
.size() -> .length 로 고쳐야 할것같습니다...
.size() 상태에선, size is not function 에러가 뜨면서 주문서페이지로 안넘어가요

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.