Coder Social home page Coder Social logo

Comments (5)

v-dobrev avatar v-dobrev commented on June 18, 2024

I think I've seen this issue before: #210.

We can add a check in the makefile with something like this:

XXD_BIN = $(or $(shell command -v xxd),$(error Required tool not found: xxd. Stop.))

I'm not sure what happens with CMake -- maybe it stops with an error if does not find xxd?

from glvis.

termi-official avatar termi-official commented on June 18, 2024

Indeed, this is the same issue.

I would also have opted for checking if xxd is installed by using command, but with ?= instead of direct assignment.

"Fixing" the cmake build should be as easy as

find_program(XXD_BIN xxd)
if(NOT XXD_BIN)
    error(FATAL_ERROR "xxd not found!")
endif()

from glvis.

termi-official avatar termi-official commented on June 18, 2024

Should I make a PR?

from glvis.

v-dobrev avatar v-dobrev commented on June 18, 2024

Should I make a PR?

A PR will be welcome! Thanks!

from glvis.

tzanio avatar tzanio commented on June 18, 2024

Discussion continued in @222

from glvis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.