glompix / openvisualizationplatform Goto Github PK

* Create new interface IController that has members common to most
rendering environments, such as output height/width, PlayerData source,
IBeatDetector source, etc.

* Rename Controller to SDLController.

* s/Controller/IController/ since Controller will no longer exist.

What steps will reproduce the problem?
1. Start banshee
2. In the preferences dialog, disable the Visualizer extension
3. Banshee crashes with the following stack trace.

I'll attach a patch.

Exception in Gtk# callback delegate
  Note: Applications can use GLib.ExceptionManager.UnhandledException to
handle the exception.
System.NullReferenceException: Object reference not set to an instance of
an object
  at Banshee.OpenVP.VisualizationDisplayWidget.OnDestroyed () [0x0000d] in
/home/lorentz/Projets/openvisualizationplatform-trunk/Banshee.OpenVP/Banshee.Ope
nVP/VisualizationDisplayWidget.cs:147

  at Gtk.Object.NativeDestroy (System.Object o, System.EventArgs args)
[0x00000] 
  at GLib.Signal.voidObjectCallback (IntPtr handle, IntPtr data) [0x00000] 
   at GLib.ExceptionManager.RaiseUnhandledException(System.Exception e,
Boolean is_terminal)
   at GLib.Signal.voidObjectCallback(IntPtr handle, IntPtr data)
   at GLib.Signal.voidObjectCallback(IntPtr , IntPtr )
   at Gtk.Object.gtk_object_destroy(IntPtr )
   at Gtk.Object.gtk_object_destroy(IntPtr )
   at Gtk.Object.Destroy()
   at Gtk.Widget.Destroy()
   at Banshee.OpenVP.OpenVPSource.Dispose() in
/home/lorentz/Projets/openvisualizationplatform-trunk/Banshee.OpenVP/Banshee.Ope
nVP/OpenVPSource.cs:line
33
   at Banshee.Sources.SourceManager.RemoveSource(Banshee.Sources.Source
source, Boolean recursivelyDispose) in
/home/lorentz/Projets/banshee/src/Core/Banshee.Services/Banshee.Sources/SourceMa
nager.cs:line
217
   at Banshee.Sources.SourceManager.OnExtensionChanged(System.Object o,
Mono.Addins.ExtensionNodeEventArgs args) in
/home/lorentz/Projets/banshee/src/Core/Banshee.Services/Banshee.Sources/SourceMa
nager.cs:line
127
   at
Mono.Addins.ExtensionNode.OnChildNodeRemoved(Mono.Addins.ExtensionNode
node) in
/var/tmp/portage/dev-dotnet/mono-addins-0.3.1/work/mono-addins-0.3.1/Mono.Addins
/Mono.Addins/ExtensionNode.cs:line
313
   at Mono.Addins.ExtensionNode.NotifyChildChanged() in
/var/tmp/portage/dev-dotnet/mono-addins-0.3.1/work/mono-addins-0.3.1/Mono.Addins
/Mono.Addins/ExtensionNode.cs:line
272
   at Mono.Addins.TreeNode.NotifyChildrenChanged() in
/var/tmp/portage/dev-dotnet/mono-addins-0.3.1/work/mono-addins-0.3.1/Mono.Addins
/Mono.Addins/TreeNode.cs:line
328
   at Mono.Addins.TreeNode.Remove() in
/var/tmp/portage/dev-dotnet/mono-addins-0.3.1/work/mono-addins-0.3.1/Mono.Addins
/Mono.Addins/TreeNode.cs:line
321
   at Mono.Addins.ExtensionContext.RemoveAddinExtensions(System.String id)
in
/var/tmp/portage/dev-dotnet/mono-addins-0.3.1/work/mono-addins-0.3.1/Mono.Addins
/Mono.Addins/ExtensionContext.cs:line
459
   at Mono.Addins.AddinSessionService.UnloadAddin(System.String id) in
/var/tmp/portage/dev-dotnet/mono-addins-0.3.1/work/mono-addins-0.3.1/Mono.Addins
/Mono.Addins/AddinSessionService.cs:line
135
   at Mono.Addins.Database.AddinDatabase.DisableAddin(System.String domain,
System.String id) in
/var/tmp/portage/dev-dotnet/mono-addins-0.3.1/work/mono-addins-0.3.1/Mono.Addins
/Mono.Addins.Database/AddinDatabase.cs:line
449
   at Mono.Addins.Addin.set_Enabled(Boolean value) in
/var/tmp/portage/dev-dotnet/mono-addins-0.3.1/work/mono-addins-0.3.1/Mono.Addins
/Mono.Addins/Addin.cs:line
111
   at Banshee.Addins.Gui.AddinTile.OnActivateClicked(System.Object o,
System.EventArgs args) in
/home/lorentz/Projets/banshee/src/Core/Banshee.ThickClient/Banshee.Addins.Gui/Ad
dinTile.cs:line
161
   at GLib.Signal.voidObjectCallback(IntPtr handle, IntPtr data)
   at GLib.Signal.voidObjectCallback(IntPtr , IntPtr )
   at Gtk.Dialog.gtk_dialog_run(IntPtr )
   at Gtk.Dialog.gtk_dialog_run(IntPtr )
   at Gtk.Dialog.Run()
   at Banshee.Gui.GlobalActions.OnPreferences(System.Object o,
System.EventArgs args) in
/home/lorentz/Projets/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/GlobalAct
ions.cs:line
229
   at GLib.Signal.voidObjectCallback(IntPtr handle, IntPtr data)
   at GLib.Signal.voidObjectCallback(IntPtr , IntPtr )
   at Gtk.Application.gtk_main()
   at Gtk.Application.gtk_main()
   at Gtk.Application.Run()
   at Banshee.Gui.GtkBaseClient.Run() in
/home/lorentz/Projets/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/GtkBaseCl
ient.cs:line
144
   at Banshee.Gui.GtkBaseClient.Startup() in
/home/lorentz/Projets/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/GtkBaseCl
ient.cs:line
77
   at Hyena.Gui.CleanRoomStartup.Startup(Hyena.Gui.StartupInvocationHandler
startup) in
/home/lorentz/Projets/banshee/src/Libraries/Hyena.Gui/Hyena.Gui/CleanRoomStartup
.cs:line
54
   at Banshee.Gui.GtkBaseClient.Startup() in
/home/lorentz/Projets/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/GtkBaseCl
ient.cs:line
72
   at Banshee.Gui.GtkBaseClient.Startup(System.String[] args) in
/home/lorentz/Projets/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/GtkBaseCl
ient.cs:line
62
   at Nereid.Client.Main(System.String[] args) in
/home/lorentz/Projets/banshee/src/Clients/Nereid/Nereid/Client.cs:line 48
~/Projets/banshee

If Banshee is not playing when attempting to quit then Banshee will freeze
and must be killed.

What steps will reproduce the problem?
1. Use openSUSE 11.0
2. Get tao dependencies from mono:community
3. Run autogen.sh on either of the openvp projects

What is the expected output? What do you see instead?

Expect successful configure, actually get failure to detect tao in
pkgconfig.  This is because the pkg-config names do not match.  With the
packages I'm using, the names are:

Tao.OpenGl.pc (not tao-opengl)
Tao.Sdl.pc (not tao-sdl)
Tao.FreeGlut.pc (not tao-freeglut)

This may just be a packaging bug; I'll update this bug when I have more
info.  If both names are valid, I may have a patch for you.

Oh, and I think instead of using compiler flags like -pkg:tao-opengl in
your Makefile.am files, you are supposed to use $(TAO_OPENGL_LIBS) or
something like that, I'll have to look it up later.

I'm using Metacity w/ compositing turned on (via gconf) with an Intel 965
card on SLED 11.

If the viz is active and I open the "select viz" dropdown, the menu is
obscured by the viz where they overlap.  You can see the menu immediately
after it's redrawn, but then the redraw of the viz hides it.

Import a MD-generated build system for the 0.0.1 branch.

What steps will reproduce the problem?
1. Start banshee
2. Do NOT click on the "Visualization" source
3. Exit banshee

What is the expected output? What do you see instead?
Banshee crashes with the following stacktrace :

[Debug 23:03:16.753] Service disposed (PlayerEngine)
Object reference not set to an instance of an object
System.NullReferenceException: Object reference not set to an instance of
an object
  at Gtk.GLWidget.Dispose () [0x00041] in
/home/lorentz/Projets/openvisualizationplatform-read-only/Banshee.OpenVP/Banshee
.OpenVP/Gtk/GLWidget.cs:111

  at Gtk.Object.NativeDestroy (System.Object o, System.EventArgs args)
[0x00000] 
  at GLib.Signal.voidObjectCallback (IntPtr handle, IntPtr gch) [0x00000] 
  at (wrapper native-to-managed) GLib.Signal:voidObjectCallback (intptr,intptr)
  at (wrapper managed-to-native) GLib.Object:g_signal_chain_from_overridden
(intptr,GLib.Value&)
  at Gtk.Object.OnDestroyed () [0x00000] 
  at Banshee.OpenVP.VisualizationDisplayWidget.OnDestroyed () [0x00000] in
/home/lorentz/Projets/openvisualizationplatform-read-only/Banshee.OpenVP/Banshee
.OpenVP/VisualizationDisplayWidget.cs:140

  at Gtk.Object.destroyed_cb (IntPtr objekt) [0x00000] 
  at (wrapper native-to-managed) Gtk.Object:destroyed_cb (intptr)
  at (wrapper managed-to-native) Gtk.Object:gtk_object_destroy (intptr)
  at Gtk.Object.Destroy () [0x00000] 
  at Gtk.Widget.Destroy () [0x00000] 
  at Banshee.OpenVP.OpenVPSource.Dispose () [0x0000b] in
/home/lorentz/Projets/openvisualizationplatform-read-only/Banshee.OpenVP/Banshee
.OpenVP/OpenVPSource.cs:37

  at Banshee.Sources.SourceManager.RemoveSource (Banshee.Sources.Source
source, Boolean recursivelyDispose) [0x000c6] in
/home/lorentz/Projets/banshee/src/Core/Banshee.Services/Banshee.Sources/SourceMa
nager.cs:210

  at Banshee.Sources.SourceManager.Dispose () [0x00063] in
/home/lorentz/Projets/banshee/src/Core/Banshee.Services/Banshee.Sources/SourceMa
nager.cs:96

  at Banshee.ServiceStack.ServiceManager.Shutdown () [0x0001c] in
/home/lorentz/Projets/banshee/src/Core/Banshee.Services/Banshee.ServiceStack/Ser
viceManager.cs:250

  at Banshee.ServiceStack.Application.Dispose () [0x00000] in
/home/lorentz/Projets/banshee/src/Core/Banshee.Services/Banshee.ServiceStack/App
lication.cs:192

  at Banshee.ServiceStack.Application.Shutdown () [0x00053] in
/home/lorentz/Projets/banshee/src/Core/Banshee.Services/Banshee.ServiceStack/App
lication.cs:106

  at Banshee.Gui.GlobalActions.OnQuit (System.Object o, System.EventArgs
args) [0x00000] in
/home/lorentz/Projets/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/GlobalAct
ions.cs:210

  at GLib.Signal.voidObjectCallback (IntPtr handle, IntPtr gch) [0x00000] 
  at (wrapper native-to-managed) GLib.Signal:voidObjectCallback (intptr,intptr)
  at (wrapper managed-to-native) Gtk.Application:gtk_main ()
  at Gtk.Application.Run () [0x00000] 
  at Banshee.Gui.GtkBaseClient.Run () [0x00027] in
/home/lorentz/Projets/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/GtkBaseCl
ient.cs:114

  at Banshee.Gui.GtkBaseClient.Startup () [0x00000] in
/home/lorentz/Projets/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/GtkBaseCl
ient.cs:55

  at Hyena.Gui.CleanRoomStartup.Startup (Hyena.Gui.StartupInvocationHandler
startup) [0x00048] in
/home/lorentz/Projets/banshee/src/Libraries/Hyena.Gui/Hyena.Gui/CleanRoomStartup
.cs:54

Stacktrace:

  at (wrapper managed-to-native) Gtk.Expander.gtk_expander_set_label_widget
(intptr,intptr) <0x00004>
  at (wrapper managed-to-native) Gtk.Expander.gtk_expander_set_label_widget
(intptr,intptr) <0xffffffff>
  at Gtk.Expander.set_LabelWidget (Gtk.Widget) <0x00034>
  at Hyena.Gui.Dialogs.ExceptionDialog..ctor (System.Exception) [0x00182]
in
/home/lorentz/Projets/banshee/src/Libraries/Hyena.Gui/Hyena.Gui.Dialogs/Exceptio
nDialog.cs:92
  at Hyena.Gui.CleanRoomStartup.Startup
(Hyena.Gui.CleanRoomStartup/StartupInvocationHandler) [0x0006d] in
/home/lorentz/Projets/banshee/src/Libraries/Hyena.Gui/Hyena.Gui/CleanRoomStartup
.cs:60
  at Banshee.Gui.GtkBaseClient.Entry () [0x00024] in
/home/lorentz/Projets/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/GtkBaseCl
ient.cs:50
  at Nereid.Client.Main (string[]) [0x0009b] in
/home/lorentz/Projets/banshee/src/Clients/Nereid/Nereid/Client.cs:77
  at (wrapper runtime-invoke) Nereid.Client.runtime_invoke_void_string[]
(object,intptr,intptr,intptr) <0xffffffff>

What steps will reproduce the problem?
1. Start banshee
2. Disable the OpenVP extension
3. Enable the OpenVP extension
4. Double click on a track to play it

Banshee crashes with the following exception :
Debug 22:11:55.843] Player state change: Loaded -> Playing
GLib.Object subclass Banshee.OpenVP.VisualizationDisplayWidget must provide
a protected or public IntPtr ctor to support wrapping of native object handles.
GLib.MissingIntPtrCtorException: GLib.Object subclass
Banshee.OpenVP.VisualizationDisplayWidget must provide a protected or
public IntPtr ctor to support wrapping of native object handles.
at GLib.ObjectManager.CreateObject (intptr) <0x00111>
at GLib.Object.GetObject (intptr,bool) <0x00158>
at Gtk.Object.destroyed_cb (intptr) <0x00010>
at (wrapper native-to-managed) Gtk.Object.destroyed_cb (intptr) <0x0003c>
at (wrapper managed-to-native) GLib.ValueArray.g_value_array_free (intptr)
<0x00004>
at GLib.ValueArray.PerformFrees () <0x000b7>
at TimeoutProxy.Handler () <0x00028>
at (wrapper native-to-managed) TimeoutProxy.Handler () <0x00040>
at (wrapper managed-to-native) Gtk.Application.gtk_main () <0x00004>
at Gtk.Application.Run () <0x00007>
at Banshee.Gui.GtkBaseClient.Run () [0x00027] in
/home/lorentz/Projets/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/GtkBaseCl
ient.cs:114
at Banshee.Gui.GtkBaseClient.Startup () [0x00000] in
/home/lorentz/Projets/banshee/src/Core/Banshee.ThickClient/Banshee.Gui/GtkBaseCl
ient.cs:55
at Hyena.Gui.CleanRoomStartup.Startup
(Hyena.Gui.CleanRoomStartup/StartupInvocationHandler) [0x00048] in
/home/lorentz/Projets/banshee/src/Libraries/Hyena.Gui/Hyena.Gui/CleanRoomStartup
.cs:54

Here's a patch that fixes the issue for me.

What steps will reproduce the problem?
1. Start banshee
2. Disable the OpenVP extension
3. Enable the OpenVP extension

I get the following exception :
System.NullReferenceException: Object reference not set to an instance of
an object
  at Mono.Addins.ExtensionNode.NotifyChildChanged () [0x0001b] in
/var/tmp/portage/dev-dotnet/mono-addins-0.3.1/work/mono-addins-0.3.1/Mono.Addins
/Mono.Addins/ExtensionNode.cs:267

  at Mono.Addins.TreeNode.NotifyChildrenChanged () [0x0000b] in
/var/tmp/portage/dev-dotnet/mono-addins-0.3.1/work/mono-addins-0.3.1/Mono.Addins
/Mono.Addins/TreeNode.cs:328

  at Mono.Addins.ExtensionTree.LoadExtensionElement (Mono.Addins.TreeNode
tnode, System.String addin,
Mono.Addins.Description.ExtensionNodeDescriptionCollection extension,
System.Int32& curPos, Mono.Addins.BaseCondition parentCondition, Boolean
inComplextCondition, System.Collections.ArrayList addedNodes) [0x00259] in
/var/tmp/portage/dev-dotnet/mono-addins-0.3.1/work/mono-addins-0.3.1/Mono.Addins
/Mono.Addins/ExtensionTree.cs:135

  at Mono.Addins.ExtensionTree.LoadExtension (System.String addin,
Mono.Addins.Description.Extension extension, System.Collections.ArrayList
addedNodes) [0x00038] in
/var/tmp/portage/dev-dotnet/mono-addins-0.3.1/work/mono-addins-0.3.1/Mono.Addins
/Mono.Addins/ExtensionTree.cs:63

  at Mono.Addins.ExtensionContext.LoadModuleExtensionNodes
(Mono.Addins.Description.Extension extension, System.String addinId,
Mono.Addins.Description.ExtensionNodeSet nset, System.Collections.ArrayList
loadedNodes) [0x00006] in
/var/tmp/portage/dev-dotnet/mono-addins-0.3.1/work/mono-addins-0.3.1/Mono.Addins
/Mono.Addins/ExtensionContext.cs:633

  at Mono.Addins.ExtensionContext.LoadExtensions (System.String
requestedExtensionPath) [0x00166] in
/var/tmp/portage/dev-dotnet/mono-addins-0.3.1/work/mono-addins-0.3.1/Mono.Addins
/Mono.Addins/ExtensionContext.cs:566

  at Mono.Addins.TreeNode.get_Children () [0x0001d] in
/var/tmp/portage/dev-dotnet/mono-addins-0.3.1/work/mono-addins-0.3.1/Mono.Addins
/Mono.Addins/TreeNode.cs:204

  at Mono.Addins.ExtensionNode.get_ChildNodes () [0x00019] in
/var/tmp/portage/dev-dotnet/mono-addins-0.3.1/work/mono-addins-0.3.1/Mono.Addins
/Mono.Addins/ExtensionNode.cs:129


The combo with the list of visualizations is then empty.

Of course, I'm only able to see that if the patch in issue #3 is applied,
but I get the exception in both cases