bban_bankid_start_offset & bban_bankid_stop_offset for GB & MT ibans not correct about php-iban

[cybercopsn]

Please provide a demonstration script including:

• Source IBAN
• Function called
• Anticipated output
• Observed output

if (file_exists(__DIR__ . '/vendor/autoload.php')) {
    require(__DIR__ . '/vendor/autoload.php');
}
$iban = "MT84MALT011000012345MTLCAST001S";
echo "IBAN: ".$iban."<br>";
$blz = iban_get_bank_part($iban);
echo "BLZ: ".$blz."<br>";
echo "Expected result: 01100<br>";
echo "Result with current registry.txt: MALT<br>";

if (file_exists(__DIR__ . '/vendor/autoload.php')) {
    require(__DIR__ . '/vendor/autoload.php');
}
$iban = "GB95REVO00996906751878";
echo "IBAN: ".$iban."<br>";
$blz = iban_get_bank_part($iban);
echo "BLZ: ".$blz."<br>";
echo "Expected result: 009969<br>";
echo "Result with current registry.txt: REVO<br>";

As I just saw, LT is working with the current offsets.

[Olympic1]

These values are already correctly defined in the registry. Are you sure it's the bankID offsets?

[cybercopsn]

I´m sure, because in the registry, for example malta, it is start 0 and end 3. But bban bank id is starting later:
MT84MALT011000012345MTLCAST001S
Same for LT and GB.
The webservice iban-rechner.de also results in this.

[globalcitizen]

Please provide a demonstration script including:

• Source IBAN
• Function called
• Anticipated output
• Observed output

[globalcitizen]

Thanks @cybercopsn, that's getting clearer. Would you be willing to submit a pull request with corrected values? I am extremely busy. Thanks.

[globalcitizen]

Not a bug. It appears you are looking for the branch part, not the bank part.

<?php
require_once('php-iban.php');
$iban = "MT84MALT011000012345MTLCAST001S";
echo "IBAN: ".$iban."\n";
print "Is valid? ";
if(verify_iban($iban)) { print "Valid.\n"; } else { print "Invalid.\n"; }
$blz = iban_get_bank_part($iban);
echo "Bank part: ".$blz."\n";
$branch = iban_get_branch_part($iban);
print "Branch part: " . $branch . "\n";
echo "Expected result: 01100\n";

print "----------------------\n";

$iban = "GB95REVO00996906751878";
echo "IBAN: ".$iban."\n";
print "Is valid? ";
if(verify_iban($iban)) { print "Valid.\n"; } else { print "Invalid.\n"; }
$blz = iban_get_bank_part($iban);
echo "Bank part: ".$blz."\n";
$branch = iban_get_branch_part($iban);
print "Branch part: " . $branch . "\n";
echo "Expected result: 009969\n";
?>

Output:

IBAN: MT84MALT011000012345MTLCAST001S
Is valid? Valid.
Bank part: MALT
Branch part: 01100
Expected result: 01100
----------------------
IBAN: GB95REVO00996906751878
Is valid? Valid.
Bank part: REVO
Branch part: 009969
Expected result: 009969