globalcitizen / php-iban Goto Github PK

Thank you for this useful library. Please consider to publish the version 
number somewhere in code or in documentation files. It would be helpful for 
integrators using/implementing library managers.

What steps will reproduce the problem?
1. set country_sepa to 1 for 'HR'

What is the expected output? What do you see instead?
iban_country_is_sepa returns false for croatia, should return true

What version of the product are you using? On what operating system?
1.4.3 OS independent

Please provide any additional information below.

keep up the good work ;)

make the variables

When a completely random string is inputted (not starting with a country code), 
a php error is generated in the function:

function _iban_country_get_info($country,$code) {
     global $_iban_registry;
     return $_iban_registry[strtoupper($country)][strtolower($code)];
}

a simple array_key_exists prevents the error:

function _iban_country_get_info($country,$code) {
     global $_iban_registry;
     if(array_key_exists(strtoupper($country), $_iban_registry))
     {
        return $_iban_registry[strtoupper($country)][strtolower($code)];
     }
     return false;
}

This might be something to implemen, ofcourse unless there's a reason why it's 
not at this point

Very nice validator!

Here it is:
PT|Portugal|0002.0123.12345678901.54|000201231234567890154|4!n4!n11!n2!n|^
(\d{4})(\d{4})(\d{11})(\d{2})$|21|PT50000201231234567890154|PT2!n4!n4!n11!
n2!n|^PT(\d{2})(\d{4})(\d{4})(\d{11})(\d{2})$|25|0|3|4|7|2009-04-13

What steps will reproduce the problem?
1. Call the verify_iban function() with certain IBANs, e.g., 
CH0209000000405529562

What is the expected output? What do you see instead?
I expect it to say that the IBAN is valid, which it is (see 
http://www.ibancalculator.com/iban_validieren.html?tx_valIBAN_pi1%5Biban%5D=CH02
09000000405529562&tx_valIBAN_pi1%5Bfi%5D=fi&no_cache=1&Action=validate+IBAN). 
Instead it returns false.
If I comment out line 139 (basically disabling gmp_mod functionality and 
reverting to the 'old method') it returns true again (as it did in a 
pre-gmp_mod version of php-iban).

What version of the product are you using? On what operating system?
I'm using php-iban 1.3.7 on CentOS 5.8 running php 5.4.11

Please provide any additional information below.
N/A

What steps will reproduce the problem?
1. verify_iban('FI21 1234-5600 0007?85');

What is the expected output? What do you see instead?

Expect false. Got true.

What version of the product are you using? On what operating system?
1.4.3

Please provide any additional information below.
Is this a feature, as iban_to_machine_format seems to filter that sort of 
things out?

Please provide any additional information below.

Is there any update of the registry for the following countries :

GP = GUADALOUOPE
GG = GUERNSEY
IM = ISLE OF MAN
JE = JERSEY
KZ = KAZAKISTAN
KW = KUWAIT
LB = LEBANON
MQ = MARTINIQUE
RE = REUNION

Many thanks for your kind attention

variable

Finland's IBAN length should be 18 instead of 40 (in registry.txt)

the used algorithm is horribly slow :(

if the iban is converted to the number-only version ($pruefsumme), use one of 
these:
---------------------------
$len = strlen($pruefsumme);
$rest = "";
$pos = 0;
while ($pos < $len) {
    $ziffern = 9-strlen($rest);
    $n = $rest . substr($pruefsumme,$pos,$ziffern);
    $rest = $n % 97;
    $pos = $pos + $ziffern;
}
$valid = $rest === 1;
--------------------------;
or in php 5:

$valid = gmp_intval(gmp_mod($pruefsumme,'97')) === 1;

greetings, Chris

The native php function split (used twice) is deprecated since php 5.3.0

explode looks like the aplicable alternative

What steps will reproduce the problem?
1. Download version 1.4.4 of the library in ZIP format
2. Open the 'VERSION' document (copy of this file from recent download 
(2013-10-29) attached)
3. Note content reflect version 1.4.0, not 1.4.4

What is the expected output? What do you see instead?
Version number in the VERSION document should match current library version.

What version of the product are you using? On what operating system?
1.4.4. Issue is system-independent

Please provide any additional information below.

would be nice if this cute lib would be available in composer, to make it 
easier to use.

see
https://packagist.org/
http://getcomposer.org/

Have you think in release php-iban library as a Composer package?

It will make to other add your library to its projects without effort.

It is very easy to make it composer compatible, as simply as adding a json file 
(with little configuration) and submiting an entry to packagist.

You can read more about composer in http://getcomposer.org

What steps will reproduce the problem?
1.verify_iban('JO94CBJO0010000000000131000302')

What is the expected output? What do you see instead?
Should be valid IBAN (according to 
http://www.ibancalculator.com/iban_validieren.html). Instead there is a warning 
and IBAN is invalid:

Warning: preg_match(): Compilation failed: unmatched parentheses at offset 10 
in /home/mbukovac/sassiecore/sassiehelpers/lib/php-iban-1.4.5/php-iban.php on 
line 28

What version of the product are you using? On what operating system?
1.4.5 on Linux

Please provide any additional information below.
This is your sample IBAN for Jordan in registry.txt. I have a similar example 
for Qatar (which I would prefer not to post here, but can email to you), which 
is also valid, but throws the same preg_match error.

Thanks.

When reviewing my code changes, please focus on:
 - Anything at all! 

After the review, I'll merge this branch into:
/trunk

for example: DE12500105170648489890
registry.txt File must correct. 

What steps will reproduce the problem?

iban_set_checksum('CH0009000000405241341')


What is the expected output? What do you see instead?

Expected IBAN: 'CH4709000000405241341'
Generated IBAN: 'CH9809000000405241341'


What version of the product are you using? On what operating system?

current stable


Please provide any additional information below.

iban_find_checksum calls iban_mod97_10 to get the correct "rest" number, but 
this method generates true or false (which is correct when called from 
iban_verify_checksum).

This patch fix issue 23 at least for 1.4.3 version.

registry.txt has incorrect information on the SEPA-status of France and 
potentially others. The reason: IBAN_Registry.txt has a phrase like "Yes, 
included GP, RE, MQ, GF, PM and YT" instead of a simple 'Yes' in that column 
and thus the parser fails.

Otherwise, this is a very excellent library!!

What version of the product are you using? On what operating system?
1.4.0

You have an error in the registry file that is provided. It is on Finlands 
config (FI). The error is that the lenght of the bban is set to 257 when it 
should be 14.

What steps will reproduce the problem?
 var_export(iban_get_parts('NL91ABNA0417164300'));

What is the expected output?
    array (
      'country' => 'NL',
      'checksum' => '91',
      'bban' => 'ABNA0417164300',
      'bank' => 'ABNA',
      'branch' => '',
      'account' => '0417164300',
    );
What do you see instead?
    array (
      'country' => 'NL',
      'checksum' => '91',
      'bban' => 'ABNA0417164300',
      'bank' => 'ABNA',
      'branch' => '',
      'account' => '',
    );


What version of the product are you using? On what operating system?
 version 1.4.0 on PHP 5.3.2 (Ubuntu)

Please provide any additional information below.
 Possible solution:
    update the NL line in registry.txt with bban_branchid_start_offset=4 and bban_branchid_stop_offset=3

 Example NL line that is working for me:
    NL|The Netherlands|041 71 64 300|ABNA0417164300|4!a10!n|^([A-Z]{4})(\d{10})$|14|NL91ABNA0417164300|NL2!n4!a10!n|^NL(\d{2})([A-Z]{4})(\d{10})$|18|0|3|4|3|2011-06-20|1

What steps will reproduce the problem?
Call iban_find_checksum() with an iban that has checksum below 10.
For example:
 $num = iban_find_checksum('FI0512003000065276');
 var_dump($num);


What is the expected output? What do you see instead?
expected: string(2) "05"
instead: int(5)


What version of the product are you using? On what operating system?
SVN revision 12
On Windows PHP 5.2.11

Please provide any additional information below.

This issue causes iban_set_checksum() to generate invalid IBAN numbers.

http://en.wikipedia.org/wiki/International_Bank_Account_Number#Generating_IBAN_c
heck_digits
 7. Subtract the remainder from 98 and, if necessary, pad with a leading 0 to make a two digit number.

Can be fixed (for example) by changing line 100 from this:
 return (98-$checksum);
to this:
 return str_pad((98-$checksum), 2, '0', STR_PAD_LEFT);

What steps will reproduce the problem?
1. Zend_Loader::loadFile('php-iban.php', '/path/to/php-iban', TRUE);

What is the expected output? What do you see instead?
In php-iban.php at line 272 the file_get_contents() fails saying it can't
find registry.txt in include_path.

Solved changing line 272 in:
$data = file_get_contents(dirname(__FILE__) . '/registry.txt');


What version of the product are you using? On what operating system?
Various platform.

Please provide any additional information below.

Issues observed include:
 * Lack of an extended test library (input/output expectations)
 * Lack of environment testing (eg. PHP gmp extension present/missing)
 * No way to test subcomponents (such as differing MOD97 routines)
 * No xdebug-style code coverage analysis for test library

php-iban.php, function _iban_country_get_info, $code is double converted to 
lower:

 $code = strtolower($code);
 if(array_key_exists($country,$_iban_registry)) {
  if(array_key_exists($code,$_iban_registry[$country])) {
--   return $_iban_registry[$country][strtolower($code)];
++   return $_iban_registry[$country][$code];
  }

I've noticed that in the file registry.txt some countries (e.g. Israel, 
Albania) are missing. Would these countries be added?

In file oophp-iban.php on line 47 the class search for " iban_find_checksun " 
but doesn't exist, i've correct with " iban_find_checksum " and it's OK.

Version 1.1.0 file zip.

Sorry 4 my english, i'm italian.

It would be great if this library was published on https://packagist.org

If you need any support with that, I'd be happy to help, but it should be a 
pretty straightforward process. Instructions can be found here: 
https://packagist.org/about