glepretre / angular-pubsub

:love_letter: Simple pubsub service for angularJS

Hi 👋, I'm Gilles

I'm a front-end developer, since 2013 💻

I turn music 🎧 and caffeine ☕ into code 👨‍💻

• 🏘️ I live and work remotely from Lyon, France 🦁🇫🇷

• ⚕️ I'm now working at @Kozea to help pharmacists to take care of us!

  • We use React, Redux, Next ...and soon Vue 💟

• 📱 Previously, I was working as @genygilles on Genymotion SaaS

  • It is built with ❤️ ...and a lot of time ⌚
  • It uses Vue, Vuetify, VueX and Cypress

• 👨‍🦳 I used to work on Geo-log 4

  • It was built with AngularJS, Bootstrap, Karma and Protractor

• 🌱 I’m currently learning to be a father 👶, and back-end 🔙

• 👉 Check out my pure HTML/CSS resume!

• ⚡ Fun fact: I am an engineer... in Chemistry! 👨‍🔬

• ✌️ Fun fact 2: Yes, I do love emojis 😬, my favorite one is 🥺

• ☘️ Fun fact 3: 3 jobs, 2 with @gentooboontoo 🤝

Take care 😗

angular-pubsub's Issues

Set up Travis CI

😁

Getting Maximum call stack size exceeded

My APP is heavily using this PubSub and now I am getting this error. I had to use $scope.$evalAsync to resolve this issue, but whats the problem next is, the scopes values are not updated immediately, but the messages are send, I am having problems to do specific action that is depended on the scope value.

I am not unsubscribing any message, because the directive should be always listening for that message.

Almost all the communication between the directives and main ctrl are done by this library ;).

Any suggestions?

Is using events more of a performance issue

Is using this service more of a performance upgrade then using angular events?

Single subscribe to message

Maybe upgrade the library, with a singlesubscribe, so that the subscribetion to message is automatically removed after the callback is called.

unit tests - parent, child communication

I have a directive that publishes a message. In the application it works great, but when creating a unit test, unit test doesn't get the message.

directive:

angularPubSub.subscribe('change-child', function () {
     angularPubSub.publish('child-changed');
});

unit test:

 beforeEach(inject(function ($compile, $rootScope, AngularPubSub) {
     scope = $rootScope.$new();
      compile = $compile;
      angularPubSub = AngularPubSub;
  }));

it('test ntNavigator events', inject(function (NO_RESULT) {
       element = compile(angular.element('<div my-dir></div>'))(scope);
       scope.$digest();

      angularPubSub.publish('change-child');

      angularPubSub.subscribe('child-changed', function () {
              console.log('dadadada')
      });
 }));

Add bower support

Add a bower.json and register it 😃