glensc / bacula-backup-mysql Goto Github PK

add

push(@shell, '--old_server');

to bacula-backup-mysql.pl supported from config

There was an issue I encountered using this script with mysqldump on Debian/Ubuntu. It would consistently ask me for my password when performing the command, and then error out saying my password was not a valid "database". I believe this is related to how the password is being passed to mysqldump (see below):

90: push(@shell, '-p', $password) if $password;

The following seemed to fix it for me:

90: push(@shell, "-p$password") if $password;

mysqldump requires passing the password directly after the "-p" parameter or it will error, at least in my experience.

Thanks

When mysqlhotcopy encounters empty database it exits with code 2304, thus causing Bacula backup to fail for entire set of MySQL databases. To avoid bogus issue, I added workaround into your script:

--- bacula-backup-mysql.pl      2012-12-21 11:21:21.000000000 -0500
+++ bacula-backup-mysql_orig.pl 2012-12-21 10:58:41.000000000 -0500
@@ -156,15 +156,7 @@
        push(@shell, $db, $dstdir);
        print ">>>> mysqlhotcopy $database\n";
 -       my $rc = system(@shell);
 -       if ($rc == 2304) {
 -               mkdir("$dstdir/$database");
 -               print "mysqlhotcopy $database empty";
 -       } elsif ($rc == 0) {
 -               print "mysqlhotcopy $database succeeded";
 -       } else {
 -               die "mysqlhotcopy failed: $rc\n";
 -       }
 +       system(@shell) == 0 or die "mysqlhotcopy failed: $?\n";

    
# put it to "production dir"
my $cluster_dir = "$backup_dir/$cluster";

Regards,
Nikolay