glen3b / glib Goto Github PK

Currently, the amount of time designated to spend on a single frame (in a SpriteSheet object) must be uniform across all frames. This enhancement proposes that each frame can have a unique amount of time which is spent on it.

The current implementation of Clone in the TextureFactory class is mostly complete, but has a few shortcomings.

• Even if the Tag object can be cloned in and of itself, the same reference as the original texture is used
• The mipmap value is not copied to the new texture
• Null textures are not cloned properly
• These shortcomings are not currently documented

Currently, the Screen class has two primary Update overloads, which are called in different cases. This should probably be cleaned up by merging them into one overload with a potentially null argument. In fixing this, I would like to maintain support for GameTime-free environments, such as XNA embedded within WinForms.

Setting FillColor or EmptyColor in the ProgressBar class is not threadsafe, and does not update the private field _textureNeedsCalculation. This means setting those fields does not immediately update the texture.

This can be fixed by changing them to properties.

The call to Mouse.GetState() transitions to unmanaged code, and is surprisingly expensive. Furthermore, it is unnecessary for most sprites in most games / projects, and on Xbox360 deployment.

Suggestion:Have the MouseState passed into the Sprite.Update(MouseState mouseState) method; if passed in value is null, do not perform mouse related functions. This will allow for a single call [per Update cycle] to Mouse.GetState(), which can be passed into sprites that need it.

Problems with this suggestion:Unfortunately, this is a base class; therefore, altering the Update() function will cause problems for projects relying on this class. Yet, this class is currently unsuitable as a generic sprite; given that Glib is relatively new, it may be worthwhile to make the modification now [and risk breaking some code] rather than leave this bug in.

There is an update in PGCGame project that demonstrates the issue:
GreatMindsRobotics/PGCGame@47f825c

Add a class, RelativeCoordinateManager, that allows API users to translate from relative coordinates (0 to 1 on all axes, decimal representing percent) to absolute coordinates on a given Viewport. The class should also offer the capability to automatically relocate IPositionable instances upon viewport size change.

The class should accept a width and height in the constructor, and (in addition to having coordinate translation and positionable tracking and locating methods), should have a method to resize its known screen size, which, in the process, will relocate tracked IPositionable instances.

The texture returned by CreateCircle creates a circle, but the bottom right hand corner of the circle looks like a rounded rectangle instead of a circle.
Tested as an overlayed texture.