glen3b / bukkitlib Goto Github PK

There should be a way, using this library (until Bukkit comes out with a similiar feature) to determine if a player disconnect event is caused by a kick. I am proposing we use the Utilities class to do this.

Utilities.isKick(PlayerQuitEvent event) should determine if the specified quit event corresponds to a kick. To do this, we need to subscribe to uncancelled kick events. Perhaps Utilities can be an internally initialized and event registered singleton. If this is the case, the singleton will store a list of kicked players' UUIDs, and remove them a tick (please check this amount) later. These UUIDs would be obtained by internally subscribing to the PlayerKickEvent. Meanwhile, if isKick is called, it can determine the nature of the disconnect by using the list of UUIDs to determine if the event was a kick.

Utilities would still be a "static class" so to speak, but a private singleton would be initialized and registered as an event handler by the GBukkitLib plugin class.

In the inventory menu, by clicking on a stack of resources in your inventory (such as one dirt) and selecting it, then (with that in cursor) clicking on a inventory menu item, your item swaps with the icon, giving you a free icon.

Suggested Fix: Prevent all inventory clicks or drops when any menu is visible, not just in the menu.

An automatic saving API should be available for plugins to automatically save configuration and custom configuration files at regular intervals, as well as call additional custom client code upon autosave. This could be implemented via a service, which client plugins add autosave listeners to.

An API should be created for the easy creation of custom configuration and plaintext files.

The scoreboard cycling utility (based on test implementation of AbstractBoardManager) only displays the last entry to players.

There should be an API for creating, detecting events on, and closing inventory-based menus. For example, a menu that can be opened by right-clicking on a clock (this is client code), an InventoryMenu can be created and opened. An InventoryEvent subclass can be fired upon clicking on a menu item, and client code could handle the event.

Have a command API system for plugins with a base command and subcommands. This should include an abstract class or interface for extending to execute a subcommand, a way to register subcommand descriptions/names/aliases/arguments, and tab complete for the subcommands (and potentially subcommand arguments).