githubtraining / intro-to-html Goto Github PK

View Code? Open in Web Editor NEW

7.0 6.0 11.0 1.96 MB

Course repo for Learning Lab course "Introduction to HTML". Template repo ➡️

Home Page: https://github.com/githubtraining/intro-to-html-template

License: Creative Commons Attribution 4.0 International

JavaScript 100.00%

learning-lab course hacktoberfest

intro-to-html's Introduction

Course: Introduction to HTML

This repository powers the Learning Lab course Introduction to HTML.

Every Learning Lab course is made up of:

a course repository, and
a template repository

The course repository is written in YAML and Markdown. The template repository could be written in any language that supports the learning objectives.

For more information on the goals of this course, check out the course-details.md.

Contribute

See something we could improve? Check out the contributing guide in the community contributors repository for more information on the types of contributions we ❤️ and instructions.

We ❤️ our community and take great care to ensure it is fun, safe and rewarding. Please review our Code of Conduct for community expectations and guidelines for reporting concerns.

License

When using the GitHub logos, be sure to follow the GitHub logo guidelines

intro-to-html's People

Contributors

Stargazers

Watchers

Forkers

deustopweb2019 amyschoen sirshend roney deustopweb gtechatfg scote488 yorgish wix-academy tililenjifoundation1 egiberne

intro-to-html's Issues

Test course on .com

While going through #20, I ran into some errors that have me uneasy about this course on .com. @hectorsector since you are auditing this course, I will assign you to this issue.

I was unable to get through the course, and I'm not quite sure why.

Respond when PR opened against the wrong branch

If a user opens a PR against the wrong branch, the app currently doesn't respond. We should probably respond with some guidance.

CSS reference in incorrect spot not detected

Bug Report

Current behavior
I purposely added the CSS in the wrong part of the HTML file, and the step completed successfully.

    <head>
        <title>My awesome web page</title>
    </head>

    <link rel="stylesheet" href="style.css">

Reproduction
Steps to reproduce the behavior in the course:

Go to Step 12.
Edit the HTML file to add the link to the CSS file but don't put it in the head block.
The bot replies back with successful completion of this step.

Expected behavior
I would expect that the bot would detect that this is not in the correct spot and give feedback on how to fix it.

Possible solution
If you have suggestions, we'd love to hear them. If not, that's ok too.

Additional context
Learning Lab v0.5.0

/cc @crichID @brianamarie @hectorsector @JasonEtco

Research learner activity

This is a placeholder to research completion rates for this course.

Template repository needs history cleaned

The template repository for this course needs to be scrubbed in its history, so that commits are only shown by githubteacher on all branches.

Updating history

Copy and paste this into your text editor. Update the "OLD_EMAIL" field with whatever committer you're trying to erase. This will only work on the current branch, and you may need to run it multiple times to account for multiple committers.

#!/bin/sh

git filter-branch -f --env-filter '

OLD_EMAIL="[email protected]"
CORRECT_NAME="GitHub Teacher"
CORRECT_EMAIL="[email protected]"

if [ "$GIT_COMMITTER_EMAIL" = "$OLD_EMAIL" ]
then
    export GIT_COMMITTER_NAME="$CORRECT_NAME"
    export GIT_COMMITTER_EMAIL="$CORRECT_EMAIL"
fi
if [ "$GIT_AUTHOR_EMAIL" = "$OLD_EMAIL" ]
then
    export GIT_AUTHOR_NAME="$CORRECT_NAME"
    export GIT_AUTHOR_EMAIL="$CORRECT_EMAIL"
fi
' --tag-name-filter cat -- --branches --tags

Validate <li> inside lists

The course currently checks for an ordered or unordered list, but it doesn't actually check for list items.

Can't apply suggested change

Bug Report

Current behavior
The instructions here: https://github.com/githubtraining/intro-to-html/blob/master/responses/06-add-image.md suggest applying the suggested change as an option, but it's not actually possible.

Reproduction
Steps to reproduce the behavior in the course:

Take the course through step 6.
Click on 'Commit suggestion' in step 7.

Expected behavior
I would expect it not to mention applying the suggested change if it's not possible.

Possible solution
Change Apply this suggested change, or follow the instructions below if you'd like to type out the code manually. to Follow the instructions below to add an image. You can use the image suggested below or link to your image of choice.

Additional context
PR to follow.

/cc @crichID @brianamarie @hectorsector @JasonEtco

No satisfying finish

Feature Request

Describe the problem/friction you are trying to solve
The other courses I've taken so far make it way more obvious that you've successfully completed the course. I was uncertain if I was done or had more steps left.

Describe your ideal solution
Some sort of congratulations you have completed the class sort of message or wording would be great to add in.

Add any considered drawbacks.

Describe alternatives you have considered
A clear and concise description of any alternative solutions or features you have considered.

/cc @crichID @brianamarie @hectorsector @JasonEtco

Bot not responding

Hello 👋 In trying to address a concern about image size, I was going through the HTML course and ran into a road bump.

I wasn't able to move on past step 8: My repository.

I also noticed a post in the community forum about the bot not responding in pull requests.

I wonder if this could be the same type of bug, that if the bot doesn't see the correct answer on the first commit, it stops listening to that branch? Not sure how to fix it, but wanted to bring it up. It could also very well be user error on my end. 😊

cc @JasonEtco @hectorsector for awareness of possible bug in production, and @a-a-ron for awareness of community forum post while on comms duty

- title: Add links
    description: Add links
    event: pull_request.synchronize
    link: '{{ repoUrl }}/pulls'
    actions:
      - type: getFileContents
        filename: index.html
        action_id: index_file
      - type: htmlContainsTag
        html: '%actions.index_file%'
        tag: a
        action_id: contains_a
      - type: gate
        left: '%actions.contains_a%'
        else:
          type: createReview
          body: 09e-links.md
          event: REQUEST_CHANGES
      - type: createReview
        body: 10-merge-third-pr.md
        event: APPROVE

Rendering of Markdown not working properly in GHES

Bug Report

Current behavior
A portions of the page for step 10 are not rendering properly.

Reproduction
Steps to reproduce the behavior in the course:

Take the course through step 10.
Note that both blocks that start with ```html do not render properly.

Expected behavior
I would expect both HTML pieces to properly render as code blocks.

Possible solution
Removing the html might fix the issue, but I don't want to do a PR with the fix in case this breaks some expected functionality for the course on GitHub.com.

Additional context
We are running v0.5.0 of Learning Lab and Version 2.19.6 of GHES.

/cc @crichID @brianamarie @hectorsector @JasonEtco

githubtraining / intro-to-html Goto Github PK

intro-to-html's Introduction

Course: Introduction to HTML

Contribute

License

intro-to-html's People

Contributors

Stargazers

Watchers

Forkers

intro-to-html's Issues

Bug Report

Updating history

Bug Report

Feature Request

Bug Report

Recommend Projects

Recommend Topics

Recommend Org