Coder Social home page Coder Social logo

Upgrade Pygments to 1.5 about linguist HOT 9 CLOSED

github avatar github commented on July 28, 2024
Upgrade Pygments to 1.5

from linguist.

Comments (9)

abevoelker avatar abevoelker commented on July 28, 2024

linguist's interface to Pygments is through pygments.rb, so you may want to open an issue over there for this. You can do better than the [1.5 revision](https://bitbucket.org/birkenfeld/pygments-main/changesets/tip/..tag(%221.5%22%29) though, as pygments.rb doesn't stick to the mainline releases - you can request the most recent revision off of Pygments's mercurial repo.

from linguist.

 avatar commented on July 28, 2024

Hmm I was told by Petros in May 2011 that you guys only used release version:

"Thanks. Please note that this has to be released first by Pygments and then we have to start using that release."

It seems that the current pygments.rb already includes the eC lexer. So all we're missing is my tiny pullrequest? :)

Thanks.

Jerome

from linguist.

abevoelker avatar abevoelker commented on July 28, 2024

Hmm, perhaps that was when linguist was still using albino to interface with Pygments? I'm not sure since I'm not a GH employee so I don't know the particulars offhand.

However, I imagine your pull request probably won't get accepted until the tests pass (rake test) 😉

1) Failure:
test_language_names_are_sorted(TestPedantic) [/tmp/linguist/test/test_pedantic.rb:17]:
eC should come after Eiffel

from linguist.

 avatar commented on July 28, 2024

Thanks. I've patched it ;)

FYI the README.md still says "The actual syntax highlighting is handled by our Pygments wrapper, Albino"

from linguist.

abevoelker avatar abevoelker commented on July 28, 2024

Sounds like you should make another pull request ;)

from linguist.

 avatar commented on July 28, 2024

For the README you mean? (The eC/languages.yml automatically got updated with the 2nd commit)
The README, I wouldn't know what to change it to!

from linguist.

abevoelker avatar abevoelker commented on July 28, 2024

Yes for the README, but I was just kidding ;). I can probably update at least the portion I know about after I get home from work tonight.

from linguist.

 avatar commented on July 28, 2024

Good :) Should I close this issue? I don't care about Pygments 1.5 update since eC is already in pygments.rb :)

from linguist.

abevoelker avatar abevoelker commented on July 28, 2024

Yeah, I would close it. If you ever update your lexer though, just open an issue on pygments.rb to get it sucked in

from linguist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.